{{ message }}
Stop the bleeding in function_prop_fuzzer#105146
Merged
Merged
Conversation
The check was removed from the ignore list on 2026-05-12 in 5192762 ("Enforce broken_determinism in the functions stress test"). Since then the `function_prop_fuzzer` job on master surfaces dozens of determinism mismatches per day across many functions (`caseWithExpression`, `if`, `substringUTF8`, `roundDown`, `arrayUnion`, `coalesce`, `ifNull`, `rightUTF8`, `nullIf`, `equals`, ...). These are pre-existing issues that pre-date the enforcement and cannot be fixed in one go; until they are individually addressed the noise drowns out other regressions caught by the same job. Re-add `broken_determinism` to the default ignore list, keeping it controllable via `--ignore-problems` for targeted work.
Contributor
This was referenced May 17, 2026
Contributor
LLVM Coverage Report
Changed lines: 1.56% (1/64) · Uncovered code |
Member
Author
robot-ch-test-poll3
added
the
pr-synced-to-cloud
This was referenced May 17, 2026
Open
This was referenced May 17, 2026
1 task
groeneai
added a commit
to groeneai/ClickHouse
that referenced
this pull request
May 27, 2026
The 2026-05-27 master merge into this PR branch accidentally undid the
master-side changes to three files unrelated to this PR's StorageMergeTree
ALTER fix:
- src/Functions/tests/gtest_functions_stress.cpp: re-introduced the
per-iteration max_execution_time / CancellationChecker /
ProcessList wiring (originally landed in ClickHouse#105146, reverted by
ClickHouse#105163, re-landed on master). Without this, function_prop_fuzzer
iterations cannot be interrupted and the job regresses to long/stuck
behavior.
- src/Interpreters/CancellationChecker.cpp: re-introduced the
'stop_thread = false' reset at the end of workerFunction so the
singleton can be restarted in tests.
- tests/queries/0_stateless/03357_join_pk_sharding.sql: re-added the
'no-tsan' tag landed by ClickHouse#105902.
Reverting these hunks restores the master versions so this PR only ships
the intended StorageMergeTree / StorageReplicatedMergeTree areNonReplicatedAlterCommands
branch and the new 04248 regression test.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines #105143 and #105144 to silence the two classes of failures that have been overwhelming the
function_prop_fuzzerjob onmastersince 2026-05-11:ProcessListforKILL-QUERY-style timeouts"). The hardening broke CI; it should be re-introduced only after the affected functions (mostlyarrayResize) are taught to honor cancellation.broken_determinismto the defaultignore_problemslist, reversing519276200b5("Enforcebroken_determinismin the functions stress test"). The check needs to be re-enabled one function at a time as the underlying determinism bugs (caseWithExpression,if,substringUTF8,roundDown,arrayUnion,coalesce,ifNull,rightUTF8,nullIf,equals, ...) are fixed.Keep in mind that CI is always right.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes
Version info
26.5.1.717