{{ message }}
Fix for whitespace bug in LIKE formatting#101931
Merged
Merged
Conversation
Contributor
clickhouse-gh
Bot
added
the
pr-bugfix
thevar1able
approved these changes
Apr 7, 2026
…iling-space-parsing
Member
|
The |
Member
|
The MSan stress test failure (MemorySanitizer: use-of-uninitialized-value, STID 4179-5154 or 4148-3044) is a known pre-existing issue unrelated to this PR. Fix: #102158 |
![clickhouse-gh[bot]](https://avatars.githubusercontent.com/in/928874?s=60&v=4){kind=small}
Member
|
The flaky check failure is fixed in #102148, let's update the branch. |
…iling-space-parsing
Address review: apply the same fix symmetrically to `ASTShowColumnsQuery::formatQueryImpl`, which used `" LIKE"` (no trailing space) before `quoteString(like)` and produced malformed output like `LIKE'%x%'`. Extend the stateless `formatQuery` test to cover this path.
1 task
Member
|
This was fixed by #105146. Let's update the branch. |
alexey-milovidov
changed the title
Contributor
LLVM Coverage Report
Changed lines: 100.00% (8/8) · Uncovered code |
Member
alexey-milovidov
added a commit
to vvo/ClickHouse
that referenced
this pull request
May 19, 2026
* Fix for whitespace bug in LIKE parsing * Fix whitespace bug in SHOW COLUMNS LIKE formatting Address review: apply the same fix symmetrically to `ASTShowColumnsQuery::formatQueryImpl`, which used `" LIKE"` (no trailing space) before `quoteString(like)` and produced malformed output like `LIKE'%x%'`. Extend the stateless `formatQuery` test to cover this path. --------- Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fixes a small whitespace bug during parsing of LIKE statement. Closes #101877
Documentation entry for user-facing changes
Version info
26.5.1.794