{{ message }}
Pin Keeper snapshots during transfer#104941
Merged
Merged
Conversation
Manage `SnapshotFileInfo` entries with a deleter that unlinks retired snapshots only after active references are released. Use `getSnapshotPin` in `read_logical_snp_obj` so snapshot removal and cross-disk moves wait for in-flight transfers. Track the cached remote `RemoteSnapshotLoader` by snapshot log index and reset it before snapshot retirement. Keep latest snapshot info as a local value so `moveSnapshotsIfNeeded` can move files once transfer and upload refs are gone. Add `test_keeper_snapshot_rotation_race` for snapshot rotation during follower recovery and deferred deletion ordering. Remove unused helpers and redundant `sync` calls; `Keeper` reads go through Raft.
Contributor
clickhouse-gh
Bot
added
the
pr-bugfix
1 task
Member
|
This was fixed by #105146. Let's update the branch. |
Contributor
LLVM Coverage Report
Changed lines: 72.73% (160/220) | lost baseline coverage: 14 line(s) · Uncovered code |
Contributor
robot-ch-test-poll2
added
the
pr-synced-to-cloud
6 tasks
This was referenced Jun 11, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin local
Keepersnapshot files while they are being transferred to recovering followers. This prevents snapshot rotation, cleanup, or cross-disk movement from removing the file behind an in-flight read.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix a race in
Keepersnapshot transfer where a snapshot could be removed or moved while it was being sent to a recovering follower.Documentation entry for user-facing changes
Version info
26.5.1.804