Pin contrib/silk to clickhouse-public branch by vadimskipin · Pull Request #105052 · ClickHouse/ClickHouse · GitHub
Skip to content

Pin contrib/silk to clickhouse-public branch#105052

Merged
davenger merged 1 commit into
masterfrom
vskipin/remove-silk-submodules
May 18, 2026
Merged

Pin contrib/silk to clickhouse-public branch#105052
davenger merged 1 commit into
masterfrom
vskipin/remove-silk-submodules

Conversation

@vadimskipin

@vadimskipin vadimskipin commented May 15, 2026

Copy link
Copy Markdown
Collaborator

Bumps the submodule from 997641b to 79a4606 (tip of clickhouse-public), which removes all nested submodules from contrib/silk/contrib.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Version info

  • Merged into: 26.5.1.748

@clickhouse-gh

clickhouse-gh Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

@clickhouse-gh clickhouse-gh Bot added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels May 15, 2026
@Algunenano Algunenano self-assigned this May 15, 2026
@vadimskipin

Copy link
Copy Markdown
Collaborator Author

@groeneai there are some failed checks - they cannot be affected by this change

@vadimskipin vadimskipin force-pushed the vskipin/remove-silk-submodules branch from 8b74f0e to 29d224b Compare May 15, 2026 21:16
@groeneai

Copy link
Copy Markdown
Contributor

@vadimskipin Confirmed — both failing tests are chronic flakes tracked in existing issues, fully unrelated to the contrib/silk bump.

PR scope: Single-line submodule pointer change (997641b79a4606), no other files touched.

Failing check: Only Unit tests (asan_ubsan, function_prop_fuzzer) — 1 of 167 checks. Two tests inside it:

Test Tracked in CIDB 14d cross-PR Started failing
FunctionsStress.stress #104877 378 failures, 37 on actual master, 183 unique PRs 2026-05-11
AllTests #105040 525 failures, 42 on actual master, 215 unique PRs 2026-05-04

Both started failing days before this PR was opened and hit hundreds of unrelated PRs — no causal link possible. Safe to ignore for merge purposes.

@alexey-milovidov

Copy link
Copy Markdown
Member

This was fixed by #105146. Let's update the branch.

Bumps the submodule from 997641b to 79a4606 (tip of clickhouse-public),
which removes all nested submodules from contrib/silk/contrib.
@vadimskipin vadimskipin force-pushed the vskipin/remove-silk-submodules branch from 29d224b to 574a244 Compare May 17, 2026 18:48
@vadimskipin

Copy link
Copy Markdown
Collaborator Author

@groeneai there is a new failure - what is this?

@groeneai

Copy link
Copy Markdown
Contributor

@vadimskipin The new failure is chronic — STID 3593-560a "Table has no columns" on Stress test (arm_msan), fully unrelated to the contrib/silk bump.

Signal Value
Failing check Stress test (arm_msan) (1 of N — all other jobs SUCCESS/SKIPPED)
Error Logical error: 'Table has no columns.' (STID: 3593-560a)
Stack DB::abortOnFailedAssertionStorageMerge::createChildrenPlans (per stack trace in report)
Tracked in #104740
Fix in flight #104919 by @azat (Fix LOGICAL_ERROR "Table has no columns." on Merge over a dangling Alias) — OPEN/MERGEABLE/BLOCKED

CIDB cross-PR evidence (30 days): 14 hits across 13 distinct PRs, only 1 master hit (2026-04-20). Affects all stress sanitizer variants (arm_msan / arm_tsan / arm_release / arm_ubsan / arm_asan_ubsan / amd_tsan). Recent unrelated PRs: #104965, #105114, #104079, #104440, #104496, #103862, #100141, #104299, #96844, #103246, #100752 — none touch contrib/silk.

PR scope reminder: contrib/silk submodule pointer change (997641b → 79a4606), no source files touched — no plausible path from a contrib submodule pin to a StorageMerge abort under server-side stress fuzzing.

The previous FunctionsStress.stress / AllTests failures from your last question were unblocked by @alexey-milovidov's #105146 merge (per his 2026-05-17 rebase directive), and they are no longer in the rollup. Once @azat's #104919 merges, the arm_msan stress flake will clear on rebase. The PR is safe to keep moving — no action needed on your side for this failure.

@davenger davenger added this pull request to the merge queue May 18, 2026
Merged via the queue into master with commit c5abe27 May 18, 2026
165 of 167 checks passed
@davenger davenger deleted the vskipin/remove-silk-submodules branch May 18, 2026 12:28
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants