Fuzzer fixes and updates by PedroTadim · Pull Request #104931 · ClickHouse/ClickHouse · GitHub
Skip to content

Fuzzer fixes and updates#104931

Merged
PedroTadim merged 29 commits into
masterfrom
prob-upt
May 18, 2026
Merged

Fuzzer fixes and updates#104931
PedroTadim merged 29 commits into
masterfrom
prob-upt

Conversation

@PedroTadim

@PedroTadim PedroTadim commented May 14, 2026

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

  • New settings and merged features in BuzzHouse (Paimon data lake, unique key).
  • Tuned probability generation for some statements in BuzzHouse.
  • Small bugfixes in AST fuzzer, plus mutate vector similarity index parameters, swap table function names.
  • Allow dump table Oracle for views and dictionaries in BuzzHouse with re-attach and backup/restore statements.
  • New server fuzzer settings and attenuate a few of them for La Casa Del Dolor CI runs.
  • Use named collections for a few more table function calls for La Casa Del Dolor as well.

Version info

  • Merged into: 26.5.1.751

@clickhouse-gh

clickhouse-gh Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

@clickhouse-gh clickhouse-gh Bot added the pr-ci label May 14, 2026
Comment thread src/Client/BuzzHouse/Generator/SQLQuery.cpp Outdated
Comment thread src/Client/BuzzHouse/Generator/StatementGenerator.cpp Outdated
Comment thread src/Client/BuzzHouse/Generator/SQLQuery.cpp
Comment thread src/Client/BuzzHouse/Generator/SQLTable.cpp Outdated
@Ergus Ergus self-assigned this May 14, 2026
Comment thread src/Client/BuzzHouse/Generator/SQLTable.cpp Outdated
Comment thread src/Client/BuzzHouse/Generator/SQLQuery.cpp Outdated

@Ergus Ergus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

I will aprobe BUT if BuzzHouse is ever run standalone with plain MySQL credentials and no named collection, the generated queries will always fail due to the comment I mentioned about the credentials. The fix is small and worth adding before merge.

Comment thread src/Client/BuzzHouse/AST/SQLProtoStr.cpp Outdated
Comment thread src/Client/BuzzHouse/Generator/SQLQuery.cpp
Comment thread src/Client/BuzzHouse/Generator/QueryOracle.cpp Outdated
Comment thread src/Common/QueryFuzzer.cpp
Comment thread src/Client/BuzzHouse/Generator/SQLTable.cpp
Comment thread src/Client/BuzzHouse/Generator/SQLQuery.cpp Outdated
Comment thread src/Client/BuzzHouse/Generator/SQLTable.cpp
Comment thread src/Client/BuzzHouse/Generator/SQLQuery.cpp
Comment thread tests/casa_del_dolor/properties.py Outdated
@PedroTadim PedroTadim enabled auto-merge May 14, 2026 15:54
Comment thread src/Client/BuzzHouse/Proto/SQLGrammar.proto
Comment thread src/Client/BuzzHouse/Proto/SQLGrammar.proto

@Ergus Ergus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment of a concern

Comment thread tests/casa_del_dolor/catalogs/tablegenerator.py
Comment thread src/Client/BuzzHouse/Generator/SQLCatalog.cpp
Comment thread tests/casa_del_dolor/catalogs/tablegenerator.py
@clickhouse-gh

clickhouse-gh Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

LLVM Coverage Report

Metric Baseline Current Δ
Lines 84.20% 84.20% +0.00%
Functions 91.40% 91.40% +0.00%
Branches 76.60% 76.60% +0.00%

Changed lines: 42.86% (48/112) | lost baseline coverage: 192 line(s) · Uncovered code

Full report · Diff report

@PedroTadim PedroTadim added this pull request to the merge queue May 18, 2026
Merged via the queue into master with commit 6b26862 May 18, 2026
164 of 166 checks passed
@PedroTadim PedroTadim deleted the prob-upt branch May 18, 2026 13:28
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants