{{ message }}
Restore broken_determinism to ignore_problems in functions stress test#105144
Closed
alexey-milovidov wants to merge 1 commit into
Closed
Restore broken_determinism to ignore_problems in functions stress test#105144alexey-milovidov wants to merge 1 commit into
alexey-milovidov wants to merge 1 commit into
Conversation
The check was removed from the ignore list on 2026-05-12 in 5192762 ("Enforce broken_determinism in the functions stress test"). Since then the `function_prop_fuzzer` job on master surfaces dozens of determinism mismatches per day across many functions (`caseWithExpression`, `if`, `substringUTF8`, `roundDown`, `arrayUnion`, `coalesce`, `ifNull`, `rightUTF8`, `nullIf`, `equals`, ...). These are pre-existing issues that pre-date the enforcement and cannot be fixed in one go; until they are individually addressed the noise drowns out other regressions caught by the same job. Re-add `broken_determinism` to the default ignore list, keeping it controllable via `--ignore-problems` for targeted work.
Contributor
1 task
Contributor
LLVM Coverage ReportChanged lines: N/A (no coverable changed lines) · Uncovered code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check was removed from the default ignore list on 2026-05-12 in
519276200b5("Enforcebroken_determinismin the functions stress test"). Since then thefunction_prop_fuzzerjob onmastersurfaces dozens of determinism mismatches per day across many functions (caseWithExpression,if,substringUTF8,roundDown,arrayUnion,coalesce,ifNull,rightUTF8,nullIf,equals, ...).These are pre-existing issues that pre-date the enforcement; they cannot all be fixed at once and the noise drowns out other regressions caught by the same job (stuck workers,
timeout_not_honored, etc.). Re-addbroken_determinismto the default ignore list, keeping it controllable via--ignore-problemsfor targeted work as the underlying issues are addressed one at a time.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes