{{ message }}
Fix unhandled exception in executable table function for invalid escape sequences#101819
Merged
alexey-milovidov merged 5 commits intoMay 18, 2026
Conversation
Member
alexey-milovidov
approved these changes
Apr 7, 2026
alexey-milovidov
left a comment
alexey-milovidov
left a comment
Member
There was a problem hiding this comment.
However, this change is good on its own.
alexey-milovidov
added
the
can be tested
Contributor
|
Workflow [PR], commit [f5e143c] Summary: ❌
AI ReviewSummaryThis PR wraps Final Verdict
|
clickhouse-gh
Bot
added
the
pr-not-for-changelog
…e-function-parse-error
![clickhouse-gh[bot]](https://avatars.githubusercontent.com/in/928874?s=60&v=4){kind=small}
The new regression check previously used `query_and_get_error`, which only verifies that some error is returned. Pre-patch behavior already returned an error, so the test could pass even if the specific mapping to `BAD_ARGUMENTS` regressed. Tighten the assertion to verify both the `BAD_ARGUMENTS` error code and the new `Failed to parse script name and arguments` message introduced by this PR. Address AI review feedback on ClickHouse#101819 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
alexey-milovidov
approved these changes
May 17, 2026
1 task
Member
|
This was fixed by #105146. Let's update the branch. |
Contributor
LLVM Coverage ReportChanged lines: 90.00% (9/10) · Uncovered code |
robot-ch-test-poll2
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#101565
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix unhandled exception in executable table function for invalid escape sequences
Documentation entry for user-facing changes
N/A: just a bug fix
Version info
26.5.1.783