iframe-proxy

rafaelks · 2019-05-10T11:56:27Z

@RocketChat/ios

…ssword

…cting WebSocket on new sessions

We can remove the else-if-condition where we are checking for the original image. This is because whenever the user selects an image for their avatar from the photo library, the cropping tool is always called. So, there will always be an .editedImage.

[NEW] Crop image before uploading avatar

…t message message date

…ayout & other fixes

…tes_support [NEW] SSL client certificates support (two-way authentication)

…feature/threads

[IMPROVEMENT] Swipe to read messages with uniform colour

[FIX] Prevent CustomEmoji image URL double url escaping

[NEW] Initial support to Threads

[CHORE] Upgrade project to latest Xcode & Swift 5

Revert "[CHORE] Upgrade project to latest Xcode & Swift 5"

… the flow, add docs links, fixed theming in some parts of the app and more

[RELEASE] Merge DEVELOP into BETA

[IMPROVEMENT] Adjustments on Threads implementation

[RELEASE] Merge DEVELOP into BETA

houndci-bot · 2019-05-10T11:56:35Z

+     - oldestMessage: This is the parameter that will be sent to the server in
+     order to get the correct page of data.
+     */
+    // swiftlint:disable function_body_length cyclomatic_complexity


Superfluous Disable Command Violation: SwiftLint rule 'cyclomatic_complexity' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

houndci-bot · 2019-05-10T11:56:35Z

+extension ThreadsViewController: ChatMessageCellProtocol {
+
+    func openThread(identifier: String) {
+        guard let controller = UIStoryboard.controller(from: "Chat", identifier: "Chat") as? MessagesViewController else {


Line Length Violation: Line should be 120 characters or less: currently 122 characters (line_length)

houndci-bot · 2019-05-10T11:56:35Z

+        return .zero
+    }
+
+    func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize {


Line Length Violation: Line should be 120 characters or less: currently 160 characters (line_length)

houndci-bot · 2019-05-10T11:56:35Z

+        return 0
+    }
+
+    func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, insetForSectionAt section: Int) -> UIEdgeInsets {


Line Length Violation: Line should be 120 characters or less: currently 162 characters (line_length)

houndci-bot · 2019-05-10T11:56:36Z

+        return 0
+    }
+
+    func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, minimumInteritemSpacingForSectionAt section: Int) -> CGFloat {


Line Length Violation: Line should be 120 characters or less: currently 175 characters (line_length)

houndci-bot · 2019-05-10T11:56:38Z

+    let threadIdentifier: String?

-    init(id: String, roomId: String, text: String, messageType: String? = nil) {
+    init(id: String, roomId: String, text: String, threadIdentifier: String? = nil, messageType: String? = nil) {


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

houndci-bot · 2019-05-10T11:56:38Z

+        internalType: String? = nil,
+        subscription: UnmanagedSubscription,
+        threadIdentifier: String? = nil,
+        id: String = String.random(18),


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

houndci-bot · 2019-05-10T11:56:38Z

+        return self.characters.count
+    }
+}
+#endif


File Line Length Violation: File should contain 400 lines or less: currently contains 1356 (file_length)

houndci-bot · 2019-05-10T11:56:39Z

+            self.advancedDelegate?.websocketDidDisconnect(socket: self, error: error)
            let userInfo = error.map{ [WebsocketDisconnectionErrorKeyName: $0] }
-            s.notificationCenter.post(name: NSNotification.Name(WebsocketDidDisconnectNotification), object: self, userInfo: userInfo)
+            NotificationCenter.default.post(name: NSNotification.Name(WebsocketDidDisconnectNotification), object: self, userInfo: userInfo)


Line Length Violation: Line should be 120 characters or less: currently 140 characters (line_length)

houndci-bot · 2019-05-10T11:56:39Z

-                    s.doDisconnect(error as NSError?)
+                let len = stream.write(data: Data(bytes: writeBuffer, count: offset-total))
+                if len <= 0 {
+                    self.doDisconnect(WSError(type: .outputStreamWriteError, message: "output stream had an error during write", code: 0))


Line Length Violation: Line should be 120 characters or less: currently 138 characters (line_length)

houndci-bot · 2019-05-10T11:56:41Z

+        XCTAssertEqual(request.value(forHTTPHeaderField: "Content-Type"), "application/json", "content type is correct")
+    }
+
+    func testProperties() {


Function Body Length Violation: Function body should span 40 lines or less excluding comments and whitespace: currently spans 47 lines (function_body_length)

houndci-bot · 2019-05-10T11:56:41Z

+    }
+
+}
+


Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)

houndci-bot · 2019-05-10T11:56:41Z

+        XCTAssertEqual(request.httpMethod, "GET", "http method is correct")
+    }
+
+    func testProperties() {


Function Body Length Violation: Function body should span 40 lines or less excluding comments and whitespace: currently spans 42 lines (function_body_length)

houndci-bot · 2019-05-10T11:56:42Z

    // MARK: Connection

-    static func connect(_ url: URL, completion: @escaping SocketCompletion) {
+    static func connect(_ url: URL, sslCertificate: SSLClientCertificate? = nil, completion: @escaping SocketCompletion) {


Line Length Violation: Line should be 120 characters or less: currently 122 characters (line_length)

houndci-bot · 2019-05-10T11:56:42Z

+     - oldestMessage: This is the parameter that will be sent to the server in
+     order to get the correct page of data.
+     */
+    // swiftlint:disable function_body_length cyclomatic_complexity


Superfluous Disable Command Violation: SwiftLint rule 'cyclomatic_complexity' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

houndci-bot · 2019-05-10T11:56:43Z

    }
+
+    func openThread(identifier: String) {
+        guard let controller = UIStoryboard.controller(from: "Chat", identifier: "Chat") as? MessagesViewController else {


Line Length Violation: Line should be 120 characters or less: currently 122 characters (line_length)

houndci-bot · 2019-05-10T11:56:44Z

+    var isCompressedReplyLayout = true

-    init(object: AnyDifferentiable, controllerContext: UIViewController?, collapsibleItemsState: [AnyHashable: Bool]) {
+    init(object: AnyDifferentiable, controllerContext: UIViewController?, collapsibleItemsState: [AnyHashable: Bool], inverted: Bool = true, compressedLayout: Bool = true) {


Line Length Violation: Line should be 120 characters or less: currently 173 characters (line_length)

houndci-bot · 2019-05-10T11:56:44Z

+                        api.sslCertificatePassword = self?.certificateFilePassword ?? ""
+                    }
+
+                    api.client(InfoClient.self).fetchLoginServices(completion: { loginServices, shouldRetrieveLoginServices in


Line Length Violation: Line should be 120 characters or less: currently 126 characters (line_length)

houndci-bot · 2019-05-10T11:56:44Z


+    @IBAction func buttonCertificateDidPressed(_ sender: Any) {
+        if let url = certificateFileURL {
+            let alert = UIAlertController(title: url.pathComponents.last ?? "", message: nil, preferredStyle: .actionSheet)


Line Length Violation: Line should be 120 characters or less: currently 123 characters (line_length)

houndci-bot · 2019-05-10T11:56:45Z

+    let threadIdentifier: String?

-    init(id: String, roomId: String, text: String, messageType: String? = nil) {
+    init(id: String, roomId: String, text: String, threadIdentifier: String? = nil, messageType: String? = nil) {


Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

codecov · 2019-05-10T12:07:34Z

Codecov Report

❗ No coverage uploaded for pull request base (master@df0e867). Click here to learn what that means.
The diff coverage is 20.09%.

@@            Coverage Diff            @@
##             master    #2697   +/-   ##
=========================================
  Coverage          ?   25.38%           
=========================================
  Files             ?      478           
  Lines             ?    18070           
  Branches          ?        0           
=========================================
  Hits              ?     4587           
  Misses            ?    13483           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df0e867...ff91589. Read the comment docs.

rafaelks and others added 30 commits February 11, 2019 10:42

Update Starscream to major update 3.x

016bf2b

Remove unused code to copy information of the server

efc3e30

Enable client certificates via HTTP & WebSockets

061199a

Start creating a Security manager to manage the Certificate data & pa…

efd0aeb

…ssword

Update CocoaPods to 1.6

a94718d

Ask user for client certificate & show it on the UI

f9788b2

Resolve many code adjustments

333fb15

Resolve deprecation of Documents controller

8b4d838

Translate all the Strings

fe01afe

Persist certificate, password & use it for initial settings & reconne…

1a394fe

…cting WebSocket on new sessions

Add ability to crop image before uploading avatar. Resolves #2632

87b19da

Merge pull request #2642 from shloak17107/crop-avatar

e15ccf1

[NEW] Crop image before uploading avatar

Map new properties of a Thread Message

5089c8f

Map new properties on Unmanaged object and test it

a4f38ca

Request details of a thread message when needed

b0c0e32

Write few tests to the new requests

6d7419c

Fixed a bug on Reactions order

98c1cb2

Resolve conflicts with develop

6f71670

#Resolves #2230 Swipe to read message different color

12e6c40

Fixed a bug on opening a new Discussion

f560468

Adjusted badge to be rounded and have a different color

6830c13

Display main thread cell component with the number of replies and las…

633ee6a

…t message message date

Create all requests for Threads

c2dbc55

Write tests to all new requests of Threads

c5d8214

Show Threads icon on navigationBar, fixed issues on the main thread l…

ea30d5f

…ayout & other fixes

Fixed build with Chinese translation missing strings

66dfee6

Merge pull request #2555 from RocketChat/feature/ssl_client_certifica…

2760f42

…tes_support [NEW] SSL client certificates support (two-way authentication)

Merge branch 'develop' of github.com:RocketChat/Rocket.Chat.iOS into …

8c1a329

…feature/threads

Merge pull request #2664 from snuff4/swipe_Color

32e5363

[IMPROVEMENT] Swipe to read messages with uniform colour

rafaelks and others added 24 commits April 30, 2019 10:58

Open thread from main thread button

9fc29d8

Icon adjustment to light

809193c

Present messages from threads using the same controller & logic

77df438

Let users reply to a thread from inside it

7c1067d

Handle opening a thread from threads list

029e69b

Update project and dependencies to Swift 5

0bd4776

Update JitsiMeet framework and MarkdownManager.swift to swift 5

fa68fad

Upgrade CI Xcode version

e9cfb24

Fix CI build: update iOS 11.2 to 11.4

cefec4d

Fix CI build: update iOS 12.0 to 12.2

bb9b0dd

Update Thread info into the title & load pages of messages

9e9e5e9

Update app version

100fec1

Merge pull request #2679 from jungeonkim/bugfix.customemoji

9c8cd64

[FIX] Prevent CustomEmoji image URL double url escaping

Fixed & adjusted all unit tests

08a9bd0

Translate the title of Threads

19ea4e0

Merge pull request #2667 from RocketChat/feature/threads

eef9a21

[NEW] Initial support to Threads

Merge pull request #2689 from RocketChat/swift5

ba49216

[CHORE] Upgrade project to latest Xcode & Swift 5

Revert "[CHORE] Upgrade project to latest Xcode & Swift 5"

320b7c4

Merge pull request #2690 from RocketChat/revert-2689-swift5

0419fc7

Revert "[CHORE] Upgrade project to latest Xcode & Swift 5"

Fixed many bugs on threads, allow user to fetch thread information on…

1e070c0

… the flow, add docs links, fixed theming in some parts of the app and more

Bump app version

2f08749

Merge pull request #2695 from RocketChat/develop

8ad90b4

[RELEASE] Merge DEVELOP into BETA

Merge pull request #2693 from RocketChat/bug/adjustments_threads

f94036f

[IMPROVEMENT] Adjustments on Threads implementation

Merge pull request #2696 from RocketChat/develop

ff91589

[RELEASE] Merge DEVELOP into BETA

rafaelks added the 💎 release: master label May 10, 2019

rafaelks added this to the 3.5.0 milestone May 10, 2019

houndci-bot reviewed May 10, 2019

View reviewed changes

rafaelks merged commit c603adc into master May 10, 2019

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

rafaelks commented May 10, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented May 10, 2019 •

edited

Loading