[CHORE] Upgrade project to latest Xcode & Swift 5 by cardoso · Pull Request #2689 · RocketChat/Rocket.Chat.iOS · GitHub
Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

[CHORE] Upgrade project to latest Xcode & Swift 5#2689

Merged
rafaelks merged 5 commits into
developfrom
swift5
May 6, 2019
Merged

[CHORE] Upgrade project to latest Xcode & Swift 5#2689
rafaelks merged 5 commits into
developfrom
swift5

Conversation

@cardoso

@cardoso cardoso commented May 3, 2019

Copy link
Copy Markdown
Member

@RocketChat/ios

List of changes:

@cardoso cardoso requested review from Sameesunkaria and rafaelks May 3, 2019 22:07
Comment thread Pods/SwipeCellKit/Source/SwipeController.swift
Comment thread Pods/SwipeCellKit/Source/SwipeActionButton.swift
Comment thread Pods/RCMarkdownParser/Pod/Classes/RCMarkdownParser.swift
Comment thread Pods/RCMarkdownParser/Pod/Classes/RCMarkdownParser.swift
Comment thread Pods/RCMarkdownParser/Pod/Classes/RCMarkdownParser.swift
Comment thread Pods/MobilePlayer/MobilePlayer/MobilePlayerViewController.swift
Comment thread Pods/MobilePlayer/MobilePlayer/MobilePlayerViewController.swift
Comment thread Pods/MobilePlayer/MobilePlayer/Extensions/UIColor+Hex.swift
Comment thread Pods/MobilePlayer/MobilePlayer/Extensions/ClosureSupport.swift
Comment thread Pods/DifferenceKit/Sources/Algorithm.swift
Comment thread Pods/DifferenceKit/Sources/Algorithm.swift
Comment thread Podfile
@codecov

codecov Bot commented May 4, 2019

Copy link
Copy Markdown

@cardoso cardoso changed the title Upgrade project to latest Xcode & Swift 5 [CHORE] Upgrade project to latest Xcode & Swift 5 May 4, 2019
@cardoso

cardoso commented May 4, 2019

Copy link
Copy Markdown
Member Author

Tests ✅ !!!

@Sameesunkaria

Copy link
Copy Markdown
Contributor

It’s building!

There are some inconsistencies with the pods on the branch. It did not build when I first pulled the changes. I had to pod install and then discard all changes made to the repo to get it to work.

That tells me some files from the pods are not added to version control.

Here are the errors on the first build
Errors on first build

@rudrankriyam

Copy link
Copy Markdown
Contributor

@rafaelks rafaelks added this to the 3.5.0 milestone May 6, 2019
@rafaelks rafaelks merged commit ba49216 into develop May 6, 2019
@rafaelks rafaelks deleted the swift5 branch May 6, 2019 15:12
@rafaelks rafaelks restored the swift5 branch May 6, 2019 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants