[NEW] Initial support to Threads#2667
Conversation
…t message message date
There was a problem hiding this comment.
Trailing Newline Violation: Files should have a single trailing newline. (trailing_newline)
| XCTAssertEqual(request.httpMethod, "GET", "http method is correct") | ||
| } | ||
|
|
||
| func testProperties() { |
There was a problem hiding this comment.
Function Body Length Violation: Function body should span 40 lines or less excluding comments and whitespace: currently spans 42 lines (function_body_length)
Codecov Report
@@ Coverage Diff @@
## develop #2667 +/- ##
==========================================
- Coverage 25.61% 25.32% -0.3%
==========================================
Files 467 478 +11
Lines 17532 18041 +509
==========================================
+ Hits 4491 4569 +78
- Misses 13041 13472 +431
Continue to review full report at Codecov.
|
| // Copyright © 2019 Rocket.Chat. All rights reserved. | ||
| // | ||
|
|
||
| // TODO: Add documentation link |
There was a problem hiding this comment.
Todo Violation: TODOs should be resolved (Add documentation link). (todo)
| // Copyright © 2019 Rocket.Chat. All rights reserved. | ||
| // | ||
|
|
||
| // TODO: Add documentation link |
There was a problem hiding this comment.
Todo Violation: TODOs should be resolved (Add documentation link). (todo)
| // Copyright © 2019 Rocket.Chat. All rights reserved. | ||
| // | ||
|
|
||
| // TODO: Add documentation link |
There was a problem hiding this comment.
Todo Violation: TODOs should be resolved (Add documentation link). (todo)
| // Copyright © 2019 Rocket.Chat. All rights reserved. | ||
| // | ||
|
|
||
| // TODO: Add documentation link |
There was a problem hiding this comment.
Todo Violation: TODOs should be resolved (Add documentation link). (todo)
| // Copyright © 2019 Rocket.Chat. All rights reserved. | ||
| // | ||
|
|
||
| // TODO: Add documentation link |
There was a problem hiding this comment.
Todo Violation: TODOs should be resolved (Add documentation link). (todo)
| // Copyright © 2019 Rocket.Chat. All rights reserved. | ||
| // | ||
|
|
||
| // TODO: Add documentation link |
There was a problem hiding this comment.
Todo Violation: TODOs should be resolved (Add documentation link). (todo)
| // Copyright © 2019 Rocket.Chat. All rights reserved. | ||
| // | ||
|
|
||
| // TODO: Add documentation link |
There was a problem hiding this comment.
Todo Violation: TODOs should be resolved (Add documentation link). (todo)
| return .zero | ||
| } | ||
|
|
||
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 160 characters (line_length)
| return 0 | ||
| } | ||
|
|
||
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, insetForSectionAt section: Int) -> UIEdgeInsets { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 162 characters (line_length)
| return 0 | ||
| } | ||
|
|
||
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, minimumInteritemSpacingForSectionAt section: Int) -> CGFloat { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 175 characters (line_length)
|
|
||
| extension ThreadsViewController { | ||
|
|
||
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, minimumLineSpacingForSectionAt section: Int) -> CGFloat { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 170 characters (line_length)
| var isInverted = true | ||
|
|
||
| init(object: AnyDifferentiable, controllerContext: UIViewController?, collapsibleItemsState: [AnyHashable: Bool]) { | ||
| init(object: AnyDifferentiable, controllerContext: UIViewController?, collapsibleItemsState: [AnyHashable: Bool], inverted: Bool = true) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 142 characters (line_length)
|
|
||
| extension ThreadsViewController { | ||
|
|
||
| override func collectionView(_ collectionView: UICollectionView, willDisplay cell: UICollectionViewCell, forItemAt indexPath: IndexPath) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 142 characters (line_length)
| var isCompressedReplyLayout = true | ||
|
|
||
| init(object: AnyDifferentiable, controllerContext: UIViewController?, collapsibleItemsState: [AnyHashable: Bool]) { | ||
| init(object: AnyDifferentiable, controllerContext: UIViewController?, collapsibleItemsState: [AnyHashable: Bool], inverted: Bool = true, compressedLayout: Bool = true) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 173 characters (line_length)
| } | ||
|
|
||
| func openThread(identifier: String) { | ||
| guard let controller = UIStoryboard.controller(from: "Chat", identifier: "Chat") as? MessagesViewController else { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 122 characters (line_length)
| let threadIdentifier: String? | ||
|
|
||
| init(id: String, roomId: String, text: String, messageType: String? = nil) { | ||
| init(id: String, roomId: String, text: String, threadIdentifier: String? = nil, messageType: String? = nil) { |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
| internalType: String? = nil, | ||
| subscription: UnmanagedSubscription, | ||
| threadIdentifier: String? = nil, | ||
| id: String = String.random(18), |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
| extension ThreadsViewController: ChatMessageCellProtocol { | ||
|
|
||
| func openThread(identifier: String) { | ||
| guard let controller = UIStoryboard.controller(from: "Chat", identifier: "Chat") as? MessagesViewController else { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 122 characters (line_length)
| XCTAssertEqual(request.value(forHTTPHeaderField: "Content-Type"), "application/json", "content type is correct") | ||
| } | ||
|
|
||
| func testProperties() { |
There was a problem hiding this comment.
Function Body Length Violation: Function body should span 40 lines or less excluding comments and whitespace: currently spans 47 lines (function_body_length)
| XCTAssertEqual(request.value(forHTTPHeaderField: "Content-Type"), "application/json", "content type is correct") | ||
| } | ||
|
|
||
| func testProperties() { |
There was a problem hiding this comment.
Function Body Length Violation: Function body should span 40 lines or less excluding comments and whitespace: currently spans 47 lines (function_body_length)
There was a problem hiding this comment.
Function Body Length Violation: Function body should span 40 lines or less excluding comments and whitespace: currently spans 47 lines (function_body_length)
2 participants
@RocketChat/ios
Closes #2660
Closes #2653