[IMPROVEMENT] Swipe to read messages with uniform colour by rudrankriyam · Pull Request #2664 · RocketChat/Rocket.Chat.iOS · GitHub
Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

[IMPROVEMENT] Swipe to read messages with uniform colour#2664

Merged
rafaelks merged 1 commit into
RocketChat:developfrom
rudrankriyam:swipe_Color
Apr 17, 2019
Merged

[IMPROVEMENT] Swipe to read messages with uniform colour#2664
rafaelks merged 1 commit into
RocketChat:developfrom
rudrankriyam:swipe_Color

Conversation

@rudrankriyam

Copy link
Copy Markdown
Contributor

@RocketChat/ios

Tiny fix to make the background colour in long swipe gesture same.

Simulator Screen Shot - iPhone SE - 2019-04-12 at 23 45 25

Closes #2230

@rudrankriyam

Copy link
Copy Markdown
Contributor Author

@rudrankriyam

Copy link
Copy Markdown
Contributor Author

@rafaelks can you review it? It is a small change, and can be added in 3.4.2 💯

@rafaelks

Copy link
Copy Markdown
Contributor

@Sameesunkaria Sameesunkaria left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response @snuff4.

The changes look good. It would still be better if we could get the UI to exactly match the one on the newer versions of iOS, but this is a step in the right direction.

@rafaelks rafaelks added this to the 3.5.0 milestone Apr 17, 2019
@rafaelks rafaelks merged commit 32e5363 into RocketChat:develop Apr 17, 2019
@rudrankriyam rudrankriyam deleted the swipe_Color branch April 17, 2019 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Swipe to read message appear different background

3 participants