[FIX] Prevent CustomEmoji image URL double url escaping by jungeonkim · Pull Request #2679 · RocketChat/Rocket.Chat.iOS · GitHub
Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

[FIX] Prevent CustomEmoji image URL double url escaping#2679

Merged
rafaelks merged 1 commit into
RocketChat:developfrom
jungeonkim:bugfix.customemoji
May 6, 2019
Merged

[FIX] Prevent CustomEmoji image URL double url escaping#2679
rafaelks merged 1 commit into
RocketChat:developfrom
jungeonkim:bugfix.customemoji

Conversation

@jungeonkim

Copy link
Copy Markdown
Contributor

@RocketChat/ios

@CLAassistant

CLAassistant commented Apr 23, 2019

Copy link
Copy Markdown

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jungeonkim jungeonkim force-pushed the bugfix.customemoji branch 3 times, most recently from 69d1c9e to 4b892d8 Compare April 28, 2019 08:47
@codecov

codecov Bot commented Apr 28, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (develop@32e5363). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2679   +/-   ##
==========================================
  Coverage           ?   25.71%           
==========================================
  Files              ?      467           
  Lines              ?    17531           
  Branches           ?        0           
==========================================
  Hits               ?     4508           
  Misses             ?    13023           
  Partials           ?        0
Impacted Files Coverage Δ
Rocket.Chat/Models/CustomEmoji.swift 88.88% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e5363...f9513bb. Read the comment docs.

@rafaelks

Copy link
Copy Markdown
Contributor

@jungeonkim Are you seeing any problem that this change will fix it?

@jungeonkim

Copy link
Copy Markdown
Contributor Author

@rafaelks Yes. I tested it to work.
This problem is not a problem with custom emoji with names in common ASCII ranges, but custom emoji with URL escaped names like Korean(for example "웃음") does not currently shown properly.

@rafaelks rafaelks merged commit 9c8cd64 into RocketChat:develop May 6, 2019
@rafaelks

rafaelks commented May 6, 2019

Copy link
Copy Markdown
Contributor

@rafaelks rafaelks added this to the 3.5.0 milestone May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants