Sunbelt Computer Software

…r Element is not called (#36114)" This reverts commit 87b9f08 because it is causing the side effects test to break on the 9.1.x branch.

…the element (#36114)" This reverts commit 1c8f179 because it is causing the side effects test to break on the 9.1.x branch.

This reverts commit d98d0db because it is causing the side effects test to break on the 9.1.x branch.

This reverts commit 7e56222 because it is causing the side effects test to break on the 9.1.x branch.

)" This reverts commit 2ed66ac because it is causing the side effects test to break on the 9.1.x branch.

…36114)" This reverts commit fa073ba because it is causing the side effects test to break on the 9.1.x branch.

…fore connecting the element (#36114)" This reverts commit 363f14c because it is causing the side effects test to break on the 9.1.x branch.

…proval (#37220) The `fw-testing` PullApprove group is really designed to capture the top level public testing API groups in packages like `common` and `router`. The compiler-cli also has some folders that contain the path segment `testing` but these should not require `fw-testing` PullApprove approval. This commit excludes the whole of `compiler-cli` package from the `fw-testing` group. PR Close #37220

…in patch branch (#37210) This commit updates the script that checks master and patch branches to ignore features with `dev-infra` scope while verifying that there are no feature commits in patch branch. It's ok and in fact desirable for dev-infra features to be on the patch branch. PR Close #37210

…g levels (#37192) Creates common logging functions at different levels. Allows for providing logging statements which are actually printed to the console based on the LOG_LEVEL environment variable. PR Close #37192

Remove bazel yarn format deprecation message to complete the removal of formatting bazel related files via yarn command command. PR Close #37148

Update docs in the micro benchmarks to include: * How to run with no turbo inlining * Where to find the profiles in the DevTools * Best way to debug benchmarks (using the profile_in_browser rather than --inspect-brk) PR Close #37140

…necting the element (#36114) (#37226) `createCustomElements()` creates some getters/setters for properties corresponding to component inputs that delegate to the `NgElementStrategy`. However, it is not guaranteed that the element's `NgElementStrategy` will have been created when these getters/setters are called, because some polyfills (e.g. `document-register-element`) do not call the constructor. Previously, trying to get/set input properties before connecting the element to the DOM (via `connectedCallback()`) would fail due to `NgElementStrategy` not being created. This commit ensures that the `NgElementStrategy` is always created before used inside the input property getters/setters (similar to how it is done for other methods of `NgElement`). Mentioned in https://github.com/angular/angular/pull/31416/files#r300326698. PR Close #36114 PR Close #37226

…37226) Previously, we had to check whether `NgElementStrategy` had been instantiated before accessing it. This was tedious and error prone, since it was easy to forget to add the check in new call sites. This commit switches to using a getter, so that the check has to be performed in one place and is transparent to call sites (including any future ones). PR Close #36114 PR Close #37226

…7226) - Remove imports that are not used. - Remove private class properties that are not used outside of the constructor. PR Close #36114 PR Close #37226

Previously, helper modules/components classes were declared even if the tests were not run (because the environment did not support Custom Elements for example). This commit moves the declaration of the helpers inside the `describe()` block, so they are not declared unnecessarily. This is in preparation of adding more helpers that need to access variables declared inside the `describe()` block. PR Close #36114 PR Close #37226

Previously, the `TestStrategy` `NgElementStrategy` used in `createCustomElement()` tests was created once and re-used in each test (due to complications related to how `customElements.register()` works). As a result, the `TestStrategy` instance's state (e.g. inputs) could be polluted from previous tests and affect subsequent ones. This commit ensures the strategy instance is reset before each test. PR Close #36114 PR Close #37226

…ent (#36114) (#37226) Previously, if an element started out as a regular `HTMLElement` (not a Custom Element) and was later upgraded to a Custom Element, any properties corresponding to component inputs that were set on the element before upgrading it would not be captured correctly and thus not reflected on the instantiated component. This commit fixes it by ensuring that such properties are captured correctly. Jira issue: [FW-2006](https://angular-team.atlassian.net/browse/FW-2006) Fixes #30848 Closes #31416 PR Close #36114 PR Close #37226

…t is not called (#36114) (#37226) Previously, the correct behavior of Angular custom elements relied on the constructor being called (and thus the `injector` property being initialized). However, some polyfills (e.g. `document-register-element`) do not call the constructor of custom elements, which resulted in the `injector` property being undefined and the `NgElementStrategy` failing to be instantiated. This commit fixes it by being tolerant to the `injector` property being undefined and falling back to the injector passed to the `createCustomElement()` config. NOTE: We don't have proper tests exercising the situation where the constructor is not called. For now this is tested using a Google internal test suite (which is how this issue was caught). This commit also adds a rudimentary unit test to emulate this situation. PR Close #36114 PR Close #37226

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

Comparing changes

Open a pull request

Commits on May 20, 2020

This comparison is taking too long to generate.

Uh oh!