Repository navigation
build: complete removal of bazel format yarn commands - #37148
josephperrott wants to merge 2 commits into
Conversation
josephperrott
added
action: merge
c8998a1 to
50f17e9
Compare
There was a problem hiding this comment.
How about we keep these in here for a bit longer, but instead of displaying a warning, we error?
TBH I didn't catch that we should be now using ng-dev format instead of yarn bazel:format and if this got merged without me randomly opening this PR I wouldn't know what to do next time I need to reformat some files.
There was a problem hiding this comment.
Currently, we already fail to perform the format and instead instruct the user to run the new command.
There was a problem hiding this comment.
you are right, I must have been lucky and not have a need to run the script because my IDE formatter does the job and I rarely need to reformat from the command line, but when I do I'd prefer to at least see a comment in package.json under scripts that reminds me to use yarn ng-dev --help instead.
There was a problem hiding this comment.
Added general note in "scripts" about our increased migration to using ng-dev
Remove bazel yarn format deprecation message to complete the removal of formatting bazel related files via yarn command command.
50f17e9 to
5b004e4
Compare
Remove bazel yarn format deprecation message to complete the removal of formatting bazel related files via yarn command command. PR Close #37148
Remove bazel yarn format deprecation message to complete the removal of formatting bazel related files via yarn command command. PR Close angular#37148
3 participants
Remove bazel yarn format deprecation message to complete the removal of
formatting bazel related files via yarn command command.