fix(dev-infra): ignore `dev-infra` scope while checking for features in patch branch by AndrewKushnir · Pull Request #37210 · angular/angular · GitHub
Skip to content

fix(dev-infra): ignore dev-infra scope while checking for features in patch branch - #37210

Closed
AndrewKushnir wants to merge 1 commit into
angular:masterfrom
AndrewKushnir:ignore_dev_infra_feat_in_patch
Closed

AndrewKushnir wants to merge 1 commit into
angular:masterfrom
AndrewKushnir:ignore_dev_infra_feat_in_patch

Conversation

@AndrewKushnir

Copy link
Copy Markdown
Contributor

This commit updates the script that checks master and patch branches to ignore features with dev-infra scope while verifying that there are no feature commits in patch branch. It's ok and in fact desirable for dev-infra features to be on the patch branch.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

…in patch branch

This commit updates the script that checks master and patch branches to ignore features with `dev-infra` scope
 while verifying that there are no feature commits in patch branch. It's ok and in fact desirable for dev-infra features to be on the patch branch.
@AndrewKushnir AndrewKushnir added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) labels May 20, 2020
@AndrewKushnir
AndrewKushnir requested a review from IgorMinar May 20, 2020 01:01
@ngbot ngbot Bot modified the milestone: needsTriage May 20, 2020

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 20, 2020
kara pushed a commit that referenced this pull request May 20, 2020
…in patch branch (#37210)

This commit updates the script that checks master and patch branches to ignore features with `dev-infra` scope
 while verifying that there are no feature commits in patch branch. It's ok and in fact desirable for dev-infra features to be on the patch branch.

PR Close #37210
@kara kara closed this in 3f4232a May 20, 2020
@angular-automatic-lock-bot

Copy link
Copy Markdown

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jun 20, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
…in patch branch (angular#37210)

This commit updates the script that checks master and patch branches to ignore features with `dev-infra` scope
 while verifying that there are no feature commits in patch branch. It's ok and in fact desirable for dev-infra features to be on the patch branch.

PR Close angular#37210
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) cla: yes target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants