{{ message }}
Repository navigation
Create logging util system in ng-dev - #37192
Closed
josephperrott wants to merge 2 commits into
Closed
josephperrott wants to merge 2 commits into
josephperrott wants to merge 2 commits into
Conversation
josephperrott
added
state: WIP
action: review
josephperrott
force-pushed
the
ng-dev-logging-common
branch
from
May 18, 2020 23:07
60f0fa0 to
6a6c71c
Compare
devversion
reviewed
May 19, 2020
josephperrott
changed the title
josephperrott
force-pushed
the
ng-dev-logging-common
branch
2 times, most recently
from
May 19, 2020 18:34
f45c471 to
6560fd3
Compare
josephperrott
added
action: merge
josephperrott
marked this pull request as ready for review
May 19, 2020 22:41
devversion
reviewed
May 20, 2020
devversion
left a comment
devversion
left a comment
Member
There was a problem hiding this comment.
When you get a chance, could you update the commit message? It seems to still mention the initial design where the --log-level flag was created.
devversion
added
the
action: cleanup
…g levels Creates common logging functions at different levels. Allows for providing logging statements which are actually printed to the console based on the LOG_LEVEL environment variable.
josephperrott
force-pushed
the
ng-dev-logging-common
branch
from
May 20, 2020 15:08
6560fd3 to
ae646cb
Compare
josephperrott
removed
the
action: cleanup
devversion
approved these changes
May 20, 2020
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…g levels (angular#37192) Creates common logging functions at different levels. Allows for providing logging statements which are actually printed to the console based on the LOG_LEVEL environment variable. PR Close angular#37192
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.