{{ message }}
Repository navigation
feat(api): add shida to named Live voices - #4053
Merged
Merged
Conversation
Castiron-Internal-PR: openai/openai-python-internal#228 Castiron-Source-SHA: 385e0da619532b6c5d250049ea29699e663b8c4e Castiron-Public-Base-SHA: c88b320
jbeckwith-oai
marked this pull request as ready for review
October 11, 2026 01:55
Contributor
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 50 mixed files remain; 0 existing customizations changed. Compared 50 existing customizations unchanged
10 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38103457293 --repo openai/openai-python \
--name castiron-custom-code-38103457293-1 --dir /tmp/castiron-custom-code-38103457293-1
git apply --stat /tmp/castiron-custom-code-38103457293-1/custom-code.patch
cat /tmp/castiron-custom-code-38103457293-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin c88b32012ef0c3ebac39c79512994985a553a24c b2377903c15db485969bc396064fc003f86f12ca
python3 scripts/castiron/custom_code_report.py report \
--base c88b32012ef0c3ebac39c79512994985a553a24c \
--head b2377903c15db485969bc396064fc003f86f12ca --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-b2377903c15d
cat /tmp/castiron-custom-code-b2377903c15d/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Contributor
OkTest Summary✅ 236/236 SDK tests passed in 9.542s for Python SDK PR #4053. Test results — 42 filesSDK merge ( |
markstuart-oai
approved these changes
Oct 11, 2026
markstuart-oai
left a comment
markstuart-oai
left a comment
Contributor
There was a problem hiding this comment.
Reviewed b2377903c15db485969bc396064fc003f86f12ca. No actionable findings.
The BuiltInVoice literal adds shida and preserves all 22 prior names. Request models retain their string alternatives, so the named alias does not narrow the accepted input. The full API reference changes only the named voice enum. This follows the existing generated structure without adding complexity.
Source and static review only; I did not run repository tests or generation. The reported GitHub checks and external OkTest run passed.
yoni-oai
approved these changes
Oct 11, 2026
Merged
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-openai__openai-python
that referenced
this pull request
Oct 11, 2026
Automated Release PR --- ## [3.29.0](openai/openai-python@v3.28.0...v3.29.0) (2026-10-11) ### Features * **api:** add billing_not_active session error code ([openai#4052](openai#4052)) ([c88b320](openai@c88b320)) * **api:** add shida to named Live voices ([openai#4053](openai#4053)) ([7352cf5](openai@7352cf5)) * **api:** add vault updates and metadata filters ([openai#4047](openai#4047)) ([e72f493](openai@e72f493)) * **api:** align beta pagination limits and non-null parameters ([openai#4057](openai#4057)) ([800899e](openai@800899e)) ### Chores * **api:** clarify decision creation documentation ([openai#4054](openai#4054)) ([16d3d3b](openai@16d3d3b)) * **api:** clarify Decisions question and answer descriptions ([openai#4051](openai#4051)) ([895d617](openai@895d617)) * **api:** document 128-character safety identifiers ([openai#4050](openai#4050)) ([2c1ae52](openai@2c1ae52)) * **api:** document decision choice constraints ([openai#4055](openai#4055)) ([b7a1990](openai@b7a1990)) * **api:** document Files API rate-limit responses ([openai#4049](openai#4049)) ([f6a3459](openai@f6a3459)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds shida to the named built-in Live voices.
Changes