feat(api): add vault updates and metadata filters by jbeckwith-oai · Pull Request #4047 · openai/openai-python · GitHub
Skip to content

feat(api): add vault updates and metadata filters - #4047

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-222
Oct 10, 2026
Merged

feat(api): add vault updates and metadata filters#4047
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-222

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds synchronous and asynchronous vault updates and metadata filtering.

Changes

  • Update a vault name or replace its metadata.

  • Filter vaults and credentials by metadata key-value pairs.

  • Preserve empty-string query filter values while continuing to omit None.

@jbeckwith-oai
feat(api): add vault updates and metadata filters
76092f4 
Castiron-Internal-PR: openai/openai-python-internal#222
Castiron-Source-SHA: e3316d44fc0685761469bd0d3876c90856046ed0
Castiron-Public-Base-SHA: ef676db
@github-actions

github-actions Bot commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 10, 2026 17:09
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 10, 2026 17:09
@openai-sdks

openai-sdks Bot commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 9.773s for Python SDK PR #4047.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 213ms
tests/chat-completions-create.test.ts ✅ Passed 287ms
tests/chat-completions-stream.test.ts ✅ Passed 278ms
tests/files-content-binary.test.ts ✅ Passed 217ms
tests/files-create-multipart.test.ts ✅ Passed 233ms
tests/files-list-pagination.test.ts ✅ Passed 304ms
tests/initialize-config.test.ts ✅ Passed 242ms
tests/instance-isolation.test.ts ✅ Passed 198ms
tests/models-list.test.ts ✅ Passed 226ms
tests/responses-background-lifecycle.test.ts ✅ Passed 195ms
tests/responses-body-method-errors.test.ts ✅ Passed 299ms
tests/responses-cancel-timeout.test.ts ✅ Passed 218ms
tests/responses-cancel.test.ts ✅ Passed 209ms
tests/responses-compact-retries.test.ts ✅ Passed 330ms
tests/responses-compact.test.ts ✅ Passed 241ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 266ms
tests/responses-create-advanced.test.ts ✅ Passed 232ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.239s
tests/responses-create-errors.test.ts ✅ Passed 171ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 271ms
tests/responses-create-retries.test.ts ✅ Passed 305ms
tests/responses-create-stream-failures.test.ts ✅ Passed 883ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 257ms
tests/responses-create-stream-wire.test.ts ✅ Passed 2.107s
tests/responses-create-stream.test.ts ✅ Passed 161ms
tests/responses-create-terminal-states.test.ts ✅ Passed 284ms
tests/responses-create-timeout.test.ts ✅ Passed 224ms
tests/responses-create.test.ts ✅ Passed 224ms
tests/responses-delete.test.ts ✅ Passed 203ms
tests/responses-input-items-errors.test.ts ✅ Passed 590ms
tests/responses-input-items-list.test.ts ✅ Passed 352ms
tests/responses-input-items-options.test.ts ✅ Passed 284ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 314ms
tests/responses-input-tokens-count.test.ts ✅ Passed 231ms
tests/responses-malformed-inputs.test.ts ✅ Passed 1.172s
tests/responses-not-found-errors.test.ts ✅ Passed 289ms
tests/responses-parse.test.ts ✅ Passed 266ms
tests/responses-retrieve-retries.test.ts ✅ Passed 479ms
tests/responses-retrieve.test.ts ✅ Passed 207ms
tests/responses-stored-method-errors.test.ts ✅ Passed 508ms
tests/retry-behavior.test.ts ✅ Passed 3.008s
tests/sdk-error-shape.test.ts ✅ Passed 313ms

View OkTest run #38070607984

SDK merge (0ba643b2e92a) · head (76092f445ecb) · base (ef676dbc199b) · OkTest (57341bb8c17e)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T17:12:13.021045Z 76092f4 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-10T17:14:05.358416Z 76092f4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

markstuart-oai
markstuart-oai approved these changes Oct 10, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 76092f445ecbaaf4ca73e1f37cf9f82718d2ca13 against ef676dbc199bc09d12a1d051f3b8b2486aa53dc2. The shared query encoder preserves explicit empty strings while still omitting None. Both vault and credential lists use that path in synchronous and asynchronous clients, and pagination retains the filters. The new transport tests inspect the outgoing metadata parameter and pin their mock base URLs.

The update methods preserve omitted fields, explicit name=None, and metadata={}. I found no actionable correctness or structural issues. Hosted tests, lint, baseline consistency, and custom-code budget checks passed on this head. I reviewed pinned source and tests; I did not run local tests or generation.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 10, 2026
Merged via the queue into main with commit e72f493 Oct 10, 2026
28 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-222 branch October 10, 2026 17:24
@openai-sdks openai-sdks Bot mentioned this pull request Oct 10, 2026
Merged
opensource-fork-sync Bot pushed a commit to cla7aye15I4nd/opensource-openai__openai-python that referenced this pull request Oct 11, 2026
@openai-sdks
release: 3.29.0 (openai#4048)
7e1643a 
Automated Release PR
---


##
[3.29.0](openai/openai-python@v3.28.0...v3.29.0)
(2026-10-11)


### Features

* **api:** add billing_not_active session error code
([openai#4052](openai#4052))
([c88b320](openai@c88b320))
* **api:** add shida to named Live voices
([openai#4053](openai#4053))
([7352cf5](openai@7352cf5))
* **api:** add vault updates and metadata filters
([openai#4047](openai#4047))
([e72f493](openai@e72f493))
* **api:** align beta pagination limits and non-null parameters
([openai#4057](openai#4057))
([800899e](openai@800899e))


### Chores

* **api:** clarify decision creation documentation
([openai#4054](openai#4054))
([16d3d3b](openai@16d3d3b))
* **api:** clarify Decisions question and answer descriptions
([openai#4051](openai#4051))
([895d617](openai@895d617))
* **api:** document 128-character safety identifiers
([openai#4050](openai#4050))
([2c1ae52](openai@2c1ae52))
* **api:** document decision choice constraints
([openai#4055](openai#4055))
([b7a1990](openai@b7a1990))
* **api:** document Files API rate-limit responses
([openai#4049](openai#4049))
([f6a3459](openai@f6a3459))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbeckwith-oai @markstuart-oai