MAINT: Fix a few typos - and sometimes improve wording by DimitriPapadopoulos · Pull Request #27376 · numpy/numpy · GitHub
Skip to content

MAINT: Fix a few typos - and sometimes improve wording#27376

Merged
charris merged 1 commit into
numpy:mainfrom
DimitriPapadopoulos:typos
Sep 11, 2024
Merged

MAINT: Fix a few typos - and sometimes improve wording#27376
charris merged 1 commit into
numpy:mainfrom
DimitriPapadopoulos:typos

Conversation

@DimitriPapadopoulos

@DimitriPapadopoulos DimitriPapadopoulos commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

Additional fixes from #27336 not in #27344.

@charris

charris commented Sep 11, 2024

Copy link
Copy Markdown
Member

@charris charris merged commit 129c6e5 into numpy:main Sep 11, 2024
@charris

charris commented Sep 11, 2024

Copy link
Copy Markdown
Member

Thanks @DimitriPapadopoulos .

charris
charris reviewed Sep 11, 2024
View reviewed changes
Comment thread meson_cpu/main_config.h.in
#ifndef @P@_CPU_DISPATCHER_CONF_H_
#define @P@_CPU_DISPATCHER_CONF_H_
/// This definition is required to provides comptablity with NumPy distutils
/// This definition is required to provide comptibility with NumPy distutils

@charris charris Sep 11, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think this is still wrong. Missed it.

@DimitriPapadopoulos DimitriPapadopoulos Sep 11, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops... I will run codespell again at some point, it should catch this typo.

@charris charris mentioned this pull request Sep 12, 2024
Closed
@bp208322 bp208322 mentioned this pull request Sep 12, 2024
Merged
@musvaage

musvaage commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

numpy/_core/src/multiarray/buffer.c

I presume requirements is contextually adequate or a better replacement string than the ticket's suggestion.

+  * Implementing PEP 3118 is somewhat convoluted because of the priorities:
-  * Implementing PEP 3118 is somewhat convoluted because of the desirata:
+  * Implementing PEP 3118 is somewhat convoluted because of the requirements:

numpy/lib/__init__.py

I presume the implemented replacement line is a better fit than the ticket's more verbose suggestion.

+     # Warn for deprecated/removed aliases, now private and nonexistent attributes
-     # Warn for reprecated attributes
+     # Warn for deprecated/removed aliases

this is only for my records

doc/release/upcoming_changes/27156.change.rst
numpy/f2py/tests/test_array_from_pyobj.py

In this pull a typo was caught in each of the above files which the work on the linked to ticket had overlooked.

@musvaage

musvaage commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

run codespell again

$ pushd numpy/numpy/_core/src/common
~/numpy/numpy/_core/src/common ~
$ grep -nr de-interlave simd && popd
simd/sse/memory.h:686: *  de-interlave load / interleave contiguous store
simd/avx2/memory.h:708: *  de-interlave load / interleave contiguous store
simd/vec/memory.h:626: *  de-interlave load / interleave contiguous store
simd/neon/memory.h:587: *  de-interlave load / interleave contiguous store
simd/avx512/memory.h:654: *  de-interlave load / interleave contiguous store
~
$ grep -n "discret " numpy/numpy/lib/_function_base_impl.py
65:#   A function used for discret methods to force the index to a specific value.
$ grep -n _discret numpy/numpy/lib/_function_base_impl.py
4636:def _discret_interpolation_to_boundaries(index, gamma_condition_fun):
4654:    return _discret_interpolation_to_boundaries((n * quantiles) - 1 - 0.5,
4660:    return _discret_interpolation_to_boundaries((n * quantiles) - 1,
$ grep -n fastests numpy/.github/workflows/linux.yml
277:        # Install using the fastests way to build (no BLAS, no SIMD)
$ grep -n whiher numpy/meson_cpu/main_config.h.in
49: * using preprocessor callback without testing whiher the
$

@DimitriPapadopoulos

DimitriPapadopoulos commented Sep 12, 2024

Copy link
Copy Markdown
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Sep 12, 2024
Merged
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 12, 2024
@DimitriPapadopoulos
Typos found in numpy
4964430 
numpy/numpy#27376
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 12, 2024
@DimitriPapadopoulos
More typos found in numpy
1636b3b 
numpy/numpy#27376 (comment)
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Sep 12, 2024
Merged
DimitriPapadopoulos added a commit to codespell-project/codespell that referenced this pull request Sep 13, 2024
@DimitriPapadopoulos
More typos found in numpy
5556f4f 
numpy/numpy#27376 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charris charris charris approved these changes

Assignees

No one assigned

Labels

03 - Maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DimitriPapadopoulos @charris @musvaage