MAINT: fix typos by musvaage · Pull Request #27344 · numpy/numpy · GitHub
Skip to content

MAINT: fix typos#27344

Merged
charris merged 1 commit into
numpy:mainfrom
vaerksted:main
Sep 11, 2024
Merged

MAINT: fix typos#27344
charris merged 1 commit into
numpy:mainfrom
vaerksted:main

Conversation

@musvaage

@musvaage musvaage commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

Closes #27336

Comment thread doc/neps/nep-0022-ndarray-duck-typing-overview.rst Outdated
Comment thread numpy/_core/tests/test_regression.py Outdated
Comment thread numpy/random/src/pcg64/pcg64.orig.h Outdated
@rkern

rkern commented Sep 4, 2024

Copy link
Copy Markdown
Member

@rkern

rkern commented Sep 4, 2024

Copy link
Copy Markdown
Member

Please don't force-push for PRs like this. It makes it very difficult to keep track of which changes have been reviewed and which still need review.

@musvaage

musvaage commented Sep 4, 2024

Copy link
Copy Markdown
Contributor Author

numpy/_core/tests/test_casting_unittests.py

presuming modifying this file is inconsequential

personally my inclination is to merge this commit which implements solely those fixes from the ticket's shell script

the ticket's ed output could later be revisited and a second pull made

@musvaage musvaage marked this pull request as ready for review September 4, 2024 17:02
@charris charris changed the title fix typos MAINT: fix typos Sep 4, 2024
@rkern

rkern commented Sep 6, 2024

Copy link
Copy Markdown
Member

The lint checks need to be fixed before merging.

@mattip

mattip commented Sep 8, 2024

Copy link
Copy Markdown
Member

Since the linting errors are in the deprecated distutils module, I don't think they should be fixed.

@mattip mattip left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through these and they all seem reasonable, including the warning/error message fixes.

@charris charris merged commit d6bfeb0 into numpy:main Sep 11, 2024
@charris

charris commented Sep 11, 2024

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

typos

4 participants