{{ message }}
MAINT: fix typos#27344
Merged
Merged
Conversation
rkern
reviewed
Sep 4, 2024
rkern
reviewed
Sep 4, 2024
rkern
reviewed
Sep 4, 2024
Member
Member
|
Please don't force-push for PRs like this. It makes it very difficult to keep track of which changes have been reviewed and which still need review. |
Contributor
Author
|
numpy/_core/tests/test_casting_unittests.py presuming modifying this file is inconsequential personally my inclination is to merge this commit which implements solely those fixes from the ticket's shell script the ticket's |
Member
|
The lint checks need to be fixed before merging. |
Member
|
Since the linting errors are in the deprecated distutils module, I don't think they should be fixed. |
mattip
approved these changes
Sep 8, 2024
mattip
left a comment
Member
There was a problem hiding this comment.
I looked through these and they all seem reasonable, including the warning/error message fixes.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #27336