MAINT: Fix a few more typos by DimitriPapadopoulos · Pull Request #27384 · numpy/numpy · GitHub
Skip to content

MAINT: Fix a few more typos#27384

Merged
mattip merged 1 commit into
numpy:mainfrom
DimitriPapadopoulos:typos
Sep 14, 2024
Merged

MAINT: Fix a few more typos#27384
mattip merged 1 commit into
numpy:mainfrom
DimitriPapadopoulos:typos

Conversation

@DimitriPapadopoulos

Copy link
Copy Markdown
Contributor

Additional typos not fixed in #27376.

I am not sure how to fix this comment:

$ grep -n wither numpy/numpy/_core/tests/test_half.py 
52:        # avoid testing NaNs due to differ bits wither Q/SNaNs
$ 

Perhaps:

        # avoid testing NaNs due to differing bits in Q/S NaNs

@charris

charris commented Sep 12, 2024

Copy link
Copy Markdown
Member

@musvaage

musvaage commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

https://www.ibm.com/docs/en/openxl-fortran-aix/17.1.2?topic=overview-infinities-nans

the above page refers to bit patterns


https://anniecherkaev.com/the-secret-life-of-nan

Annie Cherkaev
Mar 2018

@musvaage

musvaage commented Sep 13, 2024

Copy link
Copy Markdown
Contributor

quiet and signaling NaNs

deferring to a Member on this one

but if I read the content of the previous comment's cited webpages correctly then perhaps

        # avoid testing, due to different bit patterns in quiet and signaling NaNs

@musvaage

Copy link
Copy Markdown
Contributor

@seiko2plus

cf: comment on NaNs

Have you any opinion on herein proposed rewording?

@musvaage

Copy link
Copy Markdown
Contributor

numpy/_core/tests/test_half.py

the dumped comment lines from the file otherwise look good excepting the following

is been
calculations tries
mid points

$ ed -s numpy/numpy/_core/tests/test_half.py <<<'25p'
        # NaN value can cause an invalid FP exception if HW is been used
$ ed -s numpy/numpy/_core/tests/test_half.py <<<'122,126p'
        # The above calculations tries the original values, or the exact
        # mid points between the float16 values. It then further offsets them
        # by as little as possible. If no offset occurs, "round to even"
        # logic will be necessary, an arbitrarily small offset should cause
        # normal up/down rounding always.
$ 

Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
@seiko2plus

Copy link
Copy Markdown
Member

@DimitriPapadopoulos, @musvaage Thank you a lot for covering my typos.

Have you any opinion on herein proposed rewording?

Not really, but the current rewording is ideal to me:

# avoid testing NaNs due to differing bit patterns in Q/S NaNs

@musvaage

Copy link
Copy Markdown
Contributor

@mattip and @rkern

Thanks for the review on one of the predecessor PRs.


this is only for my records

BUG: Fix build on ppc64 when the baseline set to Power9 or higher #24806
charris merged 4 commits on Nov 7, 2023

cf: ENH, TST: Modify half-precision tests to deal with FP HW exceptions

MAINT: fix typos #27344
charris merged 1 commit on Sep 11, 2024

MAINT: Fix a few typos - and sometimes improve wording #27376
charris merged 1 commit on Sep 11, 2024

@mattip mattip merged commit 72b35ee into numpy:main Sep 14, 2024
@mattip

mattip commented Sep 14, 2024

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants