iframe-proxy

daniel-sanche · 2026-01-21T00:17:39Z

We currently have mypy pinned to an older version, because it fails on newer ones

This PR unpins the dependency to use the latest version, and fixes the problems it finds:

the *_operation methods in _mixins accept None values, but don't properly handle the None case
_get_default_mtls_endpoint doesn't handle what happens if the regex check returns None
the logger interceptor converts bytes to strings, without being explicit about the expected format
various type annotations didn't match the actual return type

gemini-code-assist · 2026-01-21T00:18:07Z

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses the long-standing issue of mypy being pinned to an older version by resolving several type-checking discrepancies identified by newer mypy versions. The changes involve enhancing type annotations for better accuracy, implementing robust handling for None request objects in mixin methods, and improving the string representation of pickled objects in logging. These updates collectively enable the project to utilize the latest mypy features and maintain stricter type consistency.

Highlights

Mypy Version Unpinning: The mypy dependency is unpinned, allowing the use of the latest version, which was previously restricted due to compatibility issues.
Request Object Handling: Methods in _mixins that accept request objects now explicitly handle None values by initializing an empty dictionary, ensuring proper protobuf coercion.
mTLS Endpoint Robustness: The _get_default_mtls_endpoint function now correctly handles cases where the API endpoint regex match returns None, preventing potential errors.
Logger Interceptor Clarity: The logger interceptor's conversion of bytes to strings now uses the !r format specifier for a more explicit and readable representation of pickled objects.
Type Annotation Refinements: Various type annotations across client and mixin templates have been updated to accurately reflect return types and accepted parameter types, including the use of Optional[Union[...]].

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request successfully addresses the issues identified with mypy by unpinning its version and resolving the type-related problems it exposed. The changes include adding type hints for better clarity, handling None values in request objects, and improving logging for debugging. The addition of --check-untyped-defs to the mypy configuration enhances the strictness of type checking, which is a positive step for code quality. Overall, the changes improve the robustness and maintainability of the generated code.

gemini-code-assist · 2026-01-21T00:20:24Z

+        if request is None:
+            request = {}


Initializing request to an empty dictionary when it's None is a good practice. This ensures that the subsequent isinstance(request, dict) check and keyword expansion for protobuf message construction work as expected, preventing potential TypeError or AttributeError if None was passed directly.

gemini-code-assist · 2026-01-21T00:20:24Z

+        if request is None:
+            request = {}


Initializing request to an empty dictionary when it's None is a good practice. This ensures that the subsequent isinstance(request, dict) check and keyword expansion for protobuf message construction work as expected, preventing potential TypeError or AttributeError if None was passed directly.

gemini-code-assist · 2026-01-21T00:20:24Z

+        if request is None:
+            request = {}


Initializing request to an empty dictionary when it's None is a good practice. This ensures that the subsequent isinstance(request, dict) check and keyword expansion for protobuf message construction work as expected, preventing potential TypeError or AttributeError if None was passed directly.

gemini-code-assist · 2026-01-21T00:20:25Z

+        if request is None:
+            request = {}


Initializing request to an empty dictionary when it's None is a good practice. This ensures that the subsequent isinstance(request, dict) check and keyword expansion for protobuf message construction work as expected, preventing potential TypeError or AttributeError if None was passed directly.

gemini-code-assist · 2026-01-21T00:20:25Z

+        if request is None:
+            request = {}


Initializing request to an empty dictionary when it's None is a good practice. This ensures that the subsequent isinstance(request, dict) check and keyword expansion for protobuf message construction work as expected, preventing potential TypeError or AttributeError if None was passed directly.

gemini-code-assist · 2026-01-21T00:20:25Z

+        if request is None:
+            request = {}


Initializing request to an empty dictionary when it's None is a good practice. This ensures that the subsequent isinstance(request, dict) check and keyword expansion for protobuf message construction work as expected, preventing potential TypeError or AttributeError if None was passed directly.

gemini-code-assist · 2026-01-21T00:20:25Z

+        "--check-untyped-defs",
+        *session.posargs,


Adding --check-untyped-defs to the mypy command enforces stricter type checking, which is a good practice for maintaining high code quality and catching potential type-related bugs early. Including *session.posargs also makes the nox session more flexible for custom mypy runs.

chalmerlowe · 2026-02-19T12:03:43Z

+        assert len(call.mock_calls) == 1
+        _, args, _ = call.mock_calls[0]
+        assert args[0] == operations_pb2.CancelOperationRequest()
+@pytest.mark.asyncio


There should be a blank line before this decorator to separate the tests.

This happens multiple times in the PR.

Good catch. It looks like this file was generating other methods with that same problem, even before this PR. I'm kind of surprised it's not raising any errors...

But I updated the template, so this shouldn't be a problem now

chalmerlowe

I have one comment: it looks like something is off in one of the templates OR the generation code block that is causing a test to appear immediately after another test with no intervening blank line.

Linchin

Looks good to me, seems mostly to be type annotation improvements with some additional unit test templates. But I think it makes sense to let someone with more gapic expertise to double check the tests.

daniel-sanche added 9 commits January 20, 2026 15:10

chore: unpin mypy check version

8ea95e9

updated goldens

e42c823

handle empty requests in mixins

7847002

allow dict as request type

e476732

handle none case in _get_default_mtls_endpoint

3cb8e92

add check_untyped_defs

7680213

fixed binary dump format

b8e99f4

fixed inconsistent typing in api_endpoint

75748ee

fixed typo

0118aaf

product-auto-label Bot added the size: m Pull request size is medium. label Jan 21, 2026

daniel-sanche mentioned this pull request Jan 21, 2026

feat: add return type to api_endpoint #2498

Closed

gemini-code-assist Bot reviewed Jan 21, 2026

View reviewed changes

daniel-sanche added 2 commits January 20, 2026 16:40

updated tests

fb5f0cb

fixed missing bracket

7189985

product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jan 21, 2026

daniel-sanche added 8 commits January 20, 2026 16:49

updated mypy in other noxfiles

ffd53ad

added changes to ads-templates

4e8a7a6

updated ads template tests

6664f75

updated async mixins

f394d57

updated iam templates

7b7c8dc

updated async iam methods

96f14a3

updated iam methods in ads-template

7264e63

updated some goldens

cbe19db

product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 21, 2026

daniel-sanche added 3 commits January 20, 2026 19:33

improved typing

3920092

updated more goldens

681e626

updated api_endpoint type

10007c2

updated goldens

c98f2f0

daniel-sanche marked this pull request as ready for review January 21, 2026 17:26

daniel-sanche requested a review from a team January 21, 2026 17:26

blunderbuss-gcf Bot assigned vchudnov-g Jan 21, 2026

daniel-sanche changed the title ~~[DRAFT] fix: improve type checking~~ fix: improve type checking Jan 21, 2026

daniel-sanche added 2 commits January 30, 2026 12:35

Merge branch 'main' into unpin_mypy

e5ee739

Merge branch 'main' into unpin_mypy

06b2000

daniel-sanche changed the title ~~fix: improve type checking~~ [DRAFT] fix: improve type checking Feb 4, 2026

daniel-sanche marked this pull request as draft February 4, 2026 23:17

daniel-sanche and others added 5 commits February 6, 2026 17:14

Merge branch 'main' into unpin_mypy

de47a24

removed Any from type definition

89964fc

remove Any from ads templates

0354666

capitalize comments

665c7c8

update goldens

7f6c4ac

daniel-sanche changed the title ~~[DRAFT] fix: improve type checking~~ fix: improve type checking Feb 7, 2026

daniel-sanche marked this pull request as ready for review February 7, 2026 08:52

daniel-sanche requested a review from a team as a code owner February 7, 2026 08:52

Merge branch 'main' into unpin_mypy

8d236ca

chalmerlowe reviewed Feb 19, 2026

View reviewed changes

daniel-sanche and others added 3 commits February 24, 2026 14:36

Merge branch 'main' into unpin_mypy

0fd2443

add spacing to _test_mixins

6077c20

regenerated goldens

eb825b3

Linchin approved these changes Mar 5, 2026

View reviewed changes

Merge branch 'main' into unpin_mypy

610541d

daniel-sanche merged commit bc3836b into main Mar 6, 2026
113 checks passed

daniel-sanche deleted the unpin_mypy branch March 6, 2026 19:03

daniel-sanche mentioned this pull request Mar 9, 2026

chore: librarian release pull request: 20260309T132416Z #2576

Merged

This was referenced Mar 11, 2026

Latest mypy checks fail for several generated packages #2579

Closed

tests: downgrade mypy to 1.16.0 #2580

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

daniel-sanche commented Jan 21, 2026

Uh oh!

gemini-code-assist Bot commented Jan 21, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chalmerlowe Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

daniel-sanche Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

chalmerlowe left a comment

Choose a reason for hiding this comment

Uh oh!

Linchin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants