{{ message }}
This repository was archived by the owner on Mar 26, 2026. It is now read-only.
tests: downgrade mypy to 1.16.0#2580
Merged
Merged
Conversation
Contributor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request downgrades mypy to <1.16.0 to address downstream failures, which is a reasonable temporary fix. The change is correctly applied to the noxfile.py.j2 template. However, the corresponding golden files under tests/integration/goldens/ have been manually patched instead of being regenerated from the updated template. My review includes a comment recommending that these files be regenerated to ensure consistency and adhere to the project's contribution guidelines.
ohmayr
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial revert of #2530 due to downstream mypy failures: #2579