feat: add return type to api_endpoint by daniel-sanche · Pull Request #2498 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

feat: add return type to api_endpoint#2498

Closed
daniel-sanche wants to merge 3 commits into
mainfrom
api_endpoint_type
Closed

feat: add return type to api_endpoint#2498
daniel-sanche wants to merge 3 commits into
mainfrom
api_endpoint_type

Conversation

@daniel-sanche

@daniel-sanche daniel-sanche commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

Add typing to currently untyped method

@daniel-sanche daniel-sanche requested a review from a team December 2, 2025 00:45
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Dec 2, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a return type hint to the api_endpoint property in the async client template, which improves code clarity and maintainability. To ensure consistency across the clients, a similar change should be applied to the synchronous client template as well.

@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 2, 2025
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 2, 2025
@daniel-sanche

Copy link
Copy Markdown
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants