[GHSA-952p-6rrq-rcjv] Regular Expression Denial of Service (ReDoS) in micromatch by hauserkristof · Pull Request #4714 · github/advisory-database · GitHub
Skip to content

[GHSA-952p-6rrq-rcjv] Regular Expression Denial of Service (ReDoS) in micromatch - #4714

Closed
hauserkristof wants to merge 2 commits into
hauserkristof/advisory-improvement-4714from
hauserkristof-GHSA-952p-6rrq-rcjv
Closed

hauserkristof wants to merge 2 commits into
hauserkristof/advisory-improvement-4714from
hauserkristof-GHSA-952p-6rrq-rcjv

Conversation

@hauserkristof

Copy link
Copy Markdown

Updates

  • Affected products

Comments
Only the 4.0.6 version is NOT vunerable

@github-actions
github-actions Bot changed the base branch from main to hauserkristof/advisory-improvement-4714 August 22, 2024 12:02
@darakian

Copy link
Copy Markdown
Contributor

@hauserkristof

Copy link
Copy Markdown
Author

Hey @darakian !

Yeah, it seems to be the case, that the v4.0.6 has been "mislabeled", that should be v5.0.0 and v4.0.7 does not contains the fix.

I also opened a PR micromatch/micromatch#266 for a v4.0.8 that contains the fix for the CVE. I hope it will be merged soon.

@darakian

Copy link
Copy Markdown
Contributor

Gotcha. Ya, I'd really rather avoid having dependabot tell however many millions of people Hey go update to a version that'll break everything if possible. Would you be ok waiting on 4.0.8 to release and then we can add a patched version to the advisory rather than changing the vulnerable range?

@hauserkristof

hauserkristof commented Aug 22, 2024 •

Copy link
Copy Markdown
Author

Yeah @darakian , I'll close this PR, and once 4.0.8 has been realesed either with micromatch/micromatch#266 has been merged or other, I'll open a new one with the patched version.

Also, this issue has been around for a while, but I think it is not as severe as it had been set up now...

@github-actions
github-actions Bot deleted the hauserkristof-GHSA-952p-6rrq-rcjv branch August 22, 2024 20:49
@darakian

Copy link
Copy Markdown
Contributor

Yeah @darakian , I'll close this PR, and once 4.0.8 has been realesed either with micromatch/micromatch#266 has been merged or other, I'll open a new one with the patched version.

Sounds good. I'll keep my eyes 👀 peeled for another PR so this can get resolved ASAP.

Also, this issue has been around for a while, but I think it is not as severe as it had been set up now...

Ya, severity is a weird topic. Denial of service in particular is usually a low concern for modern web app stuff where the infra just reboots a server when it locks up/crashes/whatever, but maybe it's a high concern for a car on a highway.

We really need per-project severity adjustments IMO, but failing that moderate is pretty low in the CVE world. If you look at a breakdown of CVSS 3 scores over half are high/crit as per NVD rating
https://nvd.nist.gov/general/nvd-dashboard

@hauserkristof

Copy link
Copy Markdown
Author

Hey @darakian !

The fix has been merged! 🚀

micromatch/micromatch#266

@darakian

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants