Repository navigation
Conversation
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks sound to me. I read through the code and ran the closest unit tests (src/shell/commands, src/runtime/i18n: 35 passed) and typecheck in packages/app (passed). I didn't run the desktop app or the Playwright regression myself, so I'm relying on your Windows run and screenshots for the end-to-end behaviour.
The extra useSettingsCommand() call in the titlebar is fine. Registrations use the key "settings" and only the newest one with a key is active, so mod+comma and the palette entry aren't duplicated. It also makes settings.open/settings.about available when Settings is already open, which the new e2e case covers.
The public API is unchanged: this only adds an internal hidden command (settings.about), a menu entry and an English string.
No blocking concerns.
Related: #54264
This branch has not been deployed
1 participant
Issue for this PR
Closes #51085
Ports #51433 to V2.
Type of change
What does this PR do?
Adds Help > About to the Windows menu and opens the existing Settings > About page, which already displays the desktop version. Settings commands stay registered in the titlebar so the entry also works when Settings is already open.
Only the English source string is added, following the app's localization guidelines. Other locales use the existing English fallback.
How did you verify your code works?
bun run check: passed, 34 tasks successful.Windows verification run
git diff --check: passed.typecheck:e2estill reports four errors in terminal/timeline test files; identical errors reproduced on unchanged upstream code.The browser regressions ran in Chrome on macOS using the Windows platform fixture. The additional Windows CI run used the actual Electron desktop application and server from commit
59ae6145a81749c6e56733cbd1fdcf4b0597e878.Screenshots / recordings
Full desktop screenshots captured on a GitHub-hosted Windows Server 2025 runner, running the actual Electron application from this PR (version 2.0.27).
Checklist
Added by the opencode bot (AI-generated).
Related: #54264