{{ message }}
Repository navigation
Ngtsc revert filesystem stuff - #37003
Closed
petebacondarwin wants to merge 10 commits into
Closed
petebacondarwin wants to merge 10 commits into
petebacondarwin wants to merge 10 commits into
Conversation
petebacondarwin
added
area: compiler
JoostK
approved these changes
May 8, 2020
IgorMinar
reviewed
May 8, 2020
IgorMinar
left a comment
IgorMinar
left a comment
Contributor
There was a problem hiding this comment.
Do we have a reproduction that confirms that this is the culprit?
Also, can you please update the commit messages with the rollback reason? Thanks!
…o case-sensitivity (angular#36968)" This reverts commit dcf1dcb. The changes to the case-sensitivity handling in angular#36968 caused multiple projects to fail to build. See angular#36992, angular#36993 and angular#37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further.
…ittle to case-sensitivity (angular#36968)" This reverts commit c6e5225. The changes to the case-sensitivity handling in angular#36968 caused multiple projects to fail to build. See angular#36992, angular#36993 and angular#37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further.
…ase-sensitivity (angular#36968)" This reverts commit 3361f59. The changes to the case-sensitivity handling in angular#36968 caused multiple projects to fail to build. See angular#36992, angular#36993 and angular#37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further.
…paths (angular#36968)" This reverts commit 7e9d5f5. The changes to the case-sensitivity handling in angular#36968 caused multiple projects to fail to build. See angular#36992, angular#36993 and angular#37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further.
angular#36968)" This reverts commit 654868f. The changes to the case-sensitivity handling in angular#36968 caused multiple projects to fail to build. See angular#36992, angular#36993 and angular#37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further.
…tivity (angular#36968)" This reverts commit b6c042d. The changes to the case-sensitivity handling in angular#36968 caused multiple projects to fail to build. See angular#36992, angular#36993 and angular#37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further.
…ngular#36968)" This reverts commit 4becc1b. The changes to the case-sensitivity handling in angular#36968 caused multiple projects to fail to build. See angular#36992, angular#36993 and angular#37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further.
…ivity (angular#36968)" This reverts commit 5bddeea. The changes to the case-sensitivity handling in angular#36968 caused multiple projects to fail to build. See angular#36992, angular#36993 and angular#37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further.
…itivity (angular#36968)" This reverts commit 65337fb. The changes to the case-sensitivity handling in angular#36968 caused multiple projects to fail to build. See angular#36992, angular#36993 and angular#37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further.
…erHost (angular#36968)" This reverts commit 4abd603. The changes to the case-sensitivity handling in angular#36968 caused multiple projects to fail to build. See angular#36992, angular#36993 and angular#37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further.
petebacondarwin
force-pushed
the
ngtsc-revert-filesystem-stuff
branch
from
May 8, 2020 15:40
f654536 to
e656fb0
Compare
Contributor
Author
|
Commit messages updated. |
Member
|
I can reproduce the issue on Windows and both this PR as well as #37008 solve it for me. |
AndrewKushnir
approved these changes
May 8, 2020
Contributor
|
@petebacondarwin I just noticed that the "PR target" label is missing: I believe it should be "master&patch"? |
Contributor
Author
|
Thanks for spotting that @AndrewKushnir - no this is patch only. |
Contributor
|
@petebacondarwin ok, got it. For the "10.0.0-next.X" release the plan is to fix forward with #37008? |
Contributor
Author
|
Yes. |
petebacondarwin
added
action: presubmit
Contributor
|
FYI, g3 presubmit should not be needed for this PR, since it's a patch-only (i.e. we keep these changes in master) and g3 sync happens from the master branch. |
petebacondarwin
added
merge: caretaker note
alxhub
pushed a commit
that referenced
this pull request
May 8, 2020
…o case-sensitivity (#36968)" (#37003) This reverts commit dcf1dcb. The changes to the case-sensitivity handling in #36968 caused multiple projects to fail to build. See #36992, #36993 and #37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further. PR Close #37003
alxhub
pushed a commit
that referenced
this pull request
May 8, 2020
…ittle to case-sensitivity (#36968)" (#37003) This reverts commit c6e5225. The changes to the case-sensitivity handling in #36968 caused multiple projects to fail to build. See #36992, #36993 and #37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further. PR Close #37003
alxhub
pushed a commit
that referenced
this pull request
May 8, 2020
…ase-sensitivity (#36968)" (#37003) This reverts commit 3361f59. The changes to the case-sensitivity handling in #36968 caused multiple projects to fail to build. See #36992, #36993 and #37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further. PR Close #37003
alxhub
pushed a commit
that referenced
this pull request
May 8, 2020
…paths (#36968)" (#37003) This reverts commit 7e9d5f5. The changes to the case-sensitivity handling in #36968 caused multiple projects to fail to build. See #36992, #36993 and #37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further. PR Close #37003
alxhub
pushed a commit
that referenced
this pull request
May 8, 2020
#36968)" (#37003) This reverts commit 654868f. The changes to the case-sensitivity handling in #36968 caused multiple projects to fail to build. See #36992, #36993 and #37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further. PR Close #37003
alxhub
pushed a commit
that referenced
this pull request
May 8, 2020
…tivity (#36968)" (#37003) This reverts commit b6c042d. The changes to the case-sensitivity handling in #36968 caused multiple projects to fail to build. See #36992, #36993 and #37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further. PR Close #37003
alxhub
pushed a commit
that referenced
this pull request
May 8, 2020
…36968)" (#37003) This reverts commit 4becc1b. The changes to the case-sensitivity handling in #36968 caused multiple projects to fail to build. See #36992, #36993 and #37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further. PR Close #37003
alxhub
pushed a commit
that referenced
this pull request
May 8, 2020
…ivity (#36968)" (#37003) This reverts commit 5bddeea. The changes to the case-sensitivity handling in #36968 caused multiple projects to fail to build. See #36992, #36993 and #37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further. PR Close #37003
alxhub
pushed a commit
that referenced
this pull request
May 8, 2020
…itivity (#36968)" (#37003) This reverts commit 65337fb. The changes to the case-sensitivity handling in #36968 caused multiple projects to fail to build. See #36992, #36993 and #37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further. PR Close #37003
alxhub
pushed a commit
that referenced
this pull request
May 8, 2020
…erHost (#36968)" (#37003) This reverts commit 4abd603. The changes to the case-sensitivity handling in #36968 caused multiple projects to fail to build. See #36992, #36993 and #37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further. PR Close #37003
Contributor
Author
|
Landed on 9.1.x |
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.