Patch PR for #36859 by petebacondarwin · Pull Request #36968 · angular/angular · GitHub
Skip to content

Patch PR for #36859 - #36968

Closed
petebacondarwin wants to merge 10 commits into
angular:9.1.xfrom
petebacondarwin:pr-36859-patch
Closed

Patch PR for #36859#36968
petebacondarwin wants to merge 10 commits into
angular:9.1.xfrom
petebacondarwin:pr-36859-patch

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented May 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Does this need presubmit @alxhub ?
Otherwise these changes have already been reviewed in the original PR.

@petebacondarwin petebacondarwin added type: bug/fix action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer area: compiler Issues related to `ngc`, Angular's template compiler labels May 7, 2020
@ngbot ngbot Bot modified the milestone: needsTriage May 7, 2020
@petebacondarwin
petebacondarwin changed the base branch from master to 9.1.x May 7, 2020 07:22
@pullapprove
pullapprove Bot requested a review from kara May 7, 2020 07:22
@googlebot

googlebot commented May 7, 2020

Copy link
Copy Markdown

alxhub pushed a commit that referenced this pull request May 7, 2020
@petebacondarwin @alxhub
test(compiler-cli): ensure reflection tests are not brittle to case-s…
dcf1dcb 
…ensitivity (#36968)

These tests were matching file-paths against what is retrieved from the
TS compiler. But the TS compiler paths have been canonicalised, so the
tests were brittle on case-insensitive file-systems.

PR Close #36968
@trandromeda trandromeda mentioned this pull request May 7, 2020
Closed
@wvankuipers wvankuipers mentioned this pull request May 8, 2020
Closed
petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request May 8, 2020
@petebacondarwin
Revert "test(compiler-cli): ensure reflection tests are not brittle t…
7341279 
…o case-sensitivity (angular#36968)"

This reverts commit dcf1dcb.

The changes to the case-sensitivity handling in angular#36968 caused multiple
projects to fail to build. See angular#36992, angular#36993 and angular#37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.
petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request May 8, 2020
@petebacondarwin
Revert "test(compiler-cli): ensure partial-evaluator tests are not br…
f0db6c2 
…ittle to case-sensitivity (angular#36968)"

This reverts commit c6e5225.

The changes to the case-sensitivity handling in angular#36968 caused multiple
projects to fail to build. See angular#36992, angular#36993 and angular#37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.
petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request May 8, 2020
@petebacondarwin
Revert "test(compiler-cli): ensure indexer tests are not brittle to c…
a714b8c 
…ase-sensitivity (angular#36968)"

This reverts commit 3361f59.

The changes to the case-sensitivity handling in angular#36968 caused multiple
projects to fail to build. See angular#36992, angular#36993 and angular#37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.
petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request May 8, 2020
@petebacondarwin
Revert "fix(compiler-cli): use CompilerHost to ensure canonical file …
8e317c2 
…paths (angular#36968)"

This reverts commit 7e9d5f5.

The changes to the case-sensitivity handling in angular#36968 caused multiple
projects to fail to build. See angular#36992, angular#36993 and angular#37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.
petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request May 8, 2020
@petebacondarwin
Revert "fix(compiler-cli): normalize mock Windows file paths correctly (
73d698b 
angular#36968)"

This reverts commit 654868f.

The changes to the case-sensitivity handling in angular#36968 caused multiple
projects to fail to build. See angular#36992, angular#36993 and angular#37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.
petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request May 8, 2020
@petebacondarwin
Revert "fix(compiler-cli): ensure MockFileSystem handles case-sensi…
b8abec5 
…tivity (angular#36968)"

This reverts commit b6c042d.

The changes to the case-sensitivity handling in angular#36968 caused multiple
projects to fail to build. See angular#36992, angular#36993 and angular#37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.
petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request May 8, 2020
@petebacondarwin
Revert "fix(compiler-cli): isCaseSensitive() returns correct value (a…
469c9aa 
…ngular#36968)"

This reverts commit 4becc1b.

The changes to the case-sensitivity handling in angular#36968 caused multiple
projects to fail to build. See angular#36992, angular#36993 and angular#37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.
petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request May 8, 2020
@petebacondarwin
Revert "fix(compiler-cli): ensure getRootDirs() handles case-sensit…
8c813cd 
…ivity (angular#36968)"

This reverts commit 5bddeea.

The changes to the case-sensitivity handling in angular#36968 caused multiple
projects to fail to build. See angular#36992, angular#36993 and angular#37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.
petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request May 8, 2020
@petebacondarwin
Revert "fix(compiler-cli): ensure LogicalFileSystem handles case-sens…
6963860 
…itivity (angular#36968)"

This reverts commit 65337fb.

The changes to the case-sensitivity handling in angular#36968 caused multiple
projects to fail to build. See angular#36992, angular#36993 and angular#37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.
petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request May 8, 2020
@petebacondarwin
Revert "fix(compiler-cli): fix case-sensitivity issues in NgtscCompil…
e656fb0 
…erHost (angular#36968)"

This reverts commit 4abd603.

The changes to the case-sensitivity handling in angular#36968 caused multiple
projects to fail to build. See angular#36992, angular#36993 and angular#37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.
@petebacondarwin

petebacondarwin commented May 8, 2020

Copy link
Copy Markdown
Contributor Author

Merged into 9.1.x

alxhub pushed a commit that referenced this pull request May 8, 2020
@petebacondarwin @alxhub
Revert "test(compiler-cli): ensure reflection tests are not brittle t…
be06a44 
…o case-sensitivity (#36968)" (#37003)

This reverts commit dcf1dcb.

The changes to the case-sensitivity handling in #36968 caused multiple
projects to fail to build. See #36992, #36993 and #37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.

PR Close #37003
alxhub pushed a commit that referenced this pull request May 8, 2020
@petebacondarwin @alxhub
Revert "test(compiler-cli): ensure partial-evaluator tests are not br…
04fd90e 
…ittle to case-sensitivity (#36968)" (#37003)

This reverts commit c6e5225.

The changes to the case-sensitivity handling in #36968 caused multiple
projects to fail to build. See #36992, #36993 and #37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.

PR Close #37003
alxhub pushed a commit that referenced this pull request May 8, 2020
@petebacondarwin @alxhub
Revert "test(compiler-cli): ensure indexer tests are not brittle to c…
bf446cb 
…ase-sensitivity (#36968)" (#37003)

This reverts commit 3361f59.

The changes to the case-sensitivity handling in #36968 caused multiple
projects to fail to build. See #36992, #36993 and #37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.

PR Close #37003
@IgorMinar IgorMinar mentioned this pull request May 16, 2020
Closed
2 of 3 tasks
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jun 9, 2020

Copy link
Copy Markdown

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub Awaiting requested review from alxhub
@kara kara Awaiting requested review from kara

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes type: bug/fix

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

3 participants

@petebacondarwin @googlebot @alxhub