Revert "fix(compiler-cli): use CompilerHost to ensure canonical file … · angular/angular@6cce05e · GitHub
Skip to content

Commit 6cce05e

Browse files
petebacondarwinalxhub
authored andcommitted
Revert "fix(compiler-cli): use CompilerHost to ensure canonical file paths (#36968)" (#37003)
This reverts commit 7e9d5f5. The changes to the case-sensitivity handling in #36968 caused multiple projects to fail to build. See #36992, #36993 and #37000. The issue is related to the logical path handling. But it is felt that it is safer to revert the entire PR and then to investigate further. PR Close #37003
1 parent bf446cb commit 6cce05e

5 files changed

Lines changed: 17 additions & 21 deletions

File tree

‎packages/compiler-cli/src/ngtsc/core/src/compiler.ts‎

Lines changed: 1 addition & 2 deletions

‎packages/compiler-cli/src/ngtsc/typecheck/src/context.ts‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,9 @@ export class TypeCheckContext {
3838
private typeCheckFile: TypeCheckFile;
3939

4040
constructor(
41-
private config: TypeCheckingConfig, compilerHost: ts.CompilerHost,
42-
private refEmitter: ReferenceEmitter, private reflector: ReflectionHost,
43-
typeCheckFilePath: AbsoluteFsPath) {
44-
this.typeCheckFile =
45-
new TypeCheckFile(typeCheckFilePath, config, refEmitter, reflector, compilerHost);
41+
private config: TypeCheckingConfig, private refEmitter: ReferenceEmitter,
42+
private reflector: ReflectionHost, typeCheckFilePath: AbsoluteFsPath) {
43+
this.typeCheckFile = new TypeCheckFile(typeCheckFilePath, config, refEmitter, reflector);
4644
}
4745

4846
/**

‎packages/compiler-cli/src/ngtsc/typecheck/src/type_check_file.ts‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,11 @@ export class TypeCheckFile extends Environment {
3333
private tcbStatements: ts.Statement[] = [];
3434

3535
constructor(
36-
readonly fileName: AbsoluteFsPath, config: TypeCheckingConfig, refEmitter: ReferenceEmitter,
37-
reflector: ReflectionHost, compilerHost: ts.CompilerHost) {
36+
private fileName: string, config: TypeCheckingConfig, refEmitter: ReferenceEmitter,
37+
reflector: ReflectionHost) {
3838
super(
3939
config, new ImportManager(new NoopImportRewriter(), 'i'), refEmitter, reflector,
40-
ts.createSourceFile(
41-
compilerHost.getCanonicalFileName(fileName), '', ts.ScriptTarget.Latest, true));
40+
ts.createSourceFile(fileName, '', ts.ScriptTarget.Latest, true));
4241
}
4342

4443
addTypeCheckBlock(
@@ -50,7 +49,7 @@ export class TypeCheckFile extends Environment {
5049
}
5150

5251
render(): ts.SourceFile {
53-
let source: string = this.importManager.getAllImports(this.contextFile.fileName)
52+
let source: string = this.importManager.getAllImports(this.fileName)
5453
.map(i => `import * as ${i.qualifier} from '${i.specifier}';`)
5554
.join('\n') +
5655
'\n\n';
@@ -76,7 +75,7 @@ export class TypeCheckFile extends Environment {
7675
source += '\nexport const IS_A_MODULE = true;\n';
7776

7877
return ts.createSourceFile(
79-
this.contextFile.fileName, source, ts.ScriptTarget.Latest, true, ts.ScriptKind.TS);
78+
this.fileName, source, ts.ScriptTarget.Latest, true, ts.ScriptKind.TS);
8079
}
8180

8281
getPreludeStatements(): ts.Statement[] {

‎packages/compiler-cli/src/ngtsc/typecheck/test/test_utils.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ export function typecheck(
262262
new LogicalProjectStrategy(reflectionHost, logicalFs),
263263
]);
264264
const ctx = new TypeCheckContext(
265-
{...ALL_ENABLED_CONFIG, ...config}, host, emitter, reflectionHost, typeCheckFilePath);
265+
{...ALL_ENABLED_CONFIG, ...config}, emitter, reflectionHost, typeCheckFilePath);
266266

267267
const templateUrl = 'synthetic.html';
268268
const templateFile = new ParseSourceFile(template, templateUrl);

‎packages/compiler-cli/src/ngtsc/typecheck/test/type_constructor_spec.ts‎

Lines changed: 7 additions & 7 deletions

0 commit comments

Comments
 (0)