Fix missing depth on overlay camera DoF by eh-unity · Pull Request #6549 · Unity-Technologies/Graphics · GitHub
Skip to content

Fix missing depth on overlay camera DoF#6549

Merged
phi-lira merged 9 commits into
universal/stagingfrom
universal/fix-overlay-dof
Dec 9, 2021
Merged

Fix missing depth on overlay camera DoF#6549
phi-lira merged 9 commits into
universal/stagingfrom
universal/fix-overlay-dof

Conversation

@eh-unity

@eh-unity eh-unity commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

Purpose of this PR

Fix bug case (https://issuetracker.unity3d.com/product/unity/issues/guid/1365623/)
Fix a code comment typo.


Testing status

Manually tested against bug repro project. Ran URPPostPro tests locally (pass).
Might need manual QA of overlay cameras and post processing, change could have halo effects.

sebastienlagarde and others added 7 commits December 7, 2021 11:57
…e driver bug.

URPasset has a depth texture checkbox, but that fixes the depth issue as well, but it's meant to be manual "force include depth" for case that can't be autodetected.
This one is correctly detected, but hardcode to not include depth (which is removed in this commit).
This reverts commit c2e3067.
@github-actions

github-actions Bot commented Dec 9, 2021

Copy link
Copy Markdown

@eh-unity eh-unity marked this pull request as ready for review December 9, 2021 12:13
@eh-unity eh-unity requested a review from a team as a code owner December 9, 2021 12:13
@eh-unity eh-unity requested a review from a team December 9, 2021 12:13
@phi-lira

phi-lira commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

@phi-lira phi-lira changed the base branch from master to universal/staging December 9, 2021 14:44
@phi-lira phi-lira merged commit 15cd26e into universal/staging Dec 9, 2021
@phi-lira phi-lira deleted the universal/fix-overlay-dof branch December 9, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants