{{ message }}
[HDRP] update Metal reference screenshots#6507
Merged
Merged
Conversation
sebastienlagarde
changed the title
phi-lira
added a commit
that referenced
this pull request
Dec 9, 2021
* Metal HDRP ref screenshots update (#6507) * Fix typo in comment. * Fix overlay depth. * Add test case. * Fix missing depth for overlay DoF. Workaround MacOS depth as wireframe driver bug. URPasset has a depth texture checkbox, but that fixes the depth issue as well, but it's meant to be manual "force include depth" for case that can't be autodetected. This one is correctly detected, but hardcode to not include depth (which is removed in this commit). * Revert bug workaround. It's in another PR. * Revert "Add test case." This reverts commit c2e3067. * Edit changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> Co-authored-by: Felipe Lira <felipedrl@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.