{{ message }}
[URP] Particles test fix#6735
Merged
Merged
Conversation
…iAliasing is needed only for base cameras
…mera in the stack so that the base camera can decide accordingly if the depth needs to be stored
phi-lira
approved these changes
Jan 14, 2022
phi-lira
left a comment
phi-lira
left a comment
Contributor
There was a problem hiding this comment.
Please add changelog if appropriate.
eh-unity
approved these changes
Jan 14, 2022
ellioman
approved these changes
Jan 14, 2022
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR fixes a regression introduced by this PR which caused the Vulkan deferred particle tests to fail on Yamato:
#6549
On top of fixing the particles test provides a better fix for the overlay DOF bug case:
https://issuetracker.unity3d.com/product/unity/issues/guid/1365623/
To fix the overlay issue, I've added a flag to keep track of any depth buffer requirements for postprocessing by any camera in the stack, so that the base camera can make the proper decisions about storing or discarding the scene depth.
Testing status
Local Windows Vulkan, Android Vulkan (Samsung S10 with Mali G76)
Comments to reviewers