{{ message }}
[2022.2] URP-294 - Bloom: Downscale & Max Iterations options added. #6369
Merged
Conversation
* "Add Renderer Feature" menu now uses the same menu as "Volume Overrides" * Universal Renderer help URL * Add page hash to help URL helper * Allow renderer features to use HelpURLAttribute and add it for SSAO, Decal, and Render Objects * Remove Name input for SSAO and Screen Space Shadows * Fix help URL for URP asset * Update change log * Fix change log * Remove `Attribute` suffix from attribute usage * Add docs for FilterWindow.Show * Move GetHelpURL to DocumentationUtils * Improve TryGetHelpURL interface
) * Upgraded Runtime/Materials/*.mat files. * Foundation CommonAssets/ *.mat files upgrade. * Foundation Scenes/ .mat files upgrade. * Foundation Scenes/ .renderTexture files upgrade. * Lighting CommonAssets/ .mat upgrade. * Lighting EditMode Assets .mat files upgrade. * Lighting Scenes/ .mat files upgrade. * Lighting Scenes/ .renderTexture files upgrade. * Terrain CommonAssets/ .mat files upgrade. * Terrain Scenes/ .mat files upgrade. * PostProcessing CommonAssets/ .mat files upgrade. * PostProcessing Scenes/ .mat files upgrade.
…g when a camera renders to a texture (#6274)
* update reference images * Update HDRP failing test reference images * Add HDRP Linux Vulkan test images * Rename UniversalHybridTest to BatchRendererGroup_URP * Move vulkan win ref images to None folder * Rename HDRP_HybridTests to BatchRenderGroup_HDRP * replace hybrid with BRG and add to nightly * Fix HDRP project name type * fix typo * Add .meta files of added reference images * remove playmode_xr * Update RenderBRG.cs scripts from hrnext-bugfix * Update BrgGameojbects hdrp reference images after master merge * Add vulkan to HDRP brg windows * use gpu for build, remove osx from ci * apply patch from the [Yamato] Formatting job * add BRG to nightly [skip ci] * remove the hybrid projects from repoconfig Co-authored-by: MingWai Chan <mingwai@unity3d.com> Co-authored-by: Tomas Kiniulis <tomas.kiniulis@unity3d.com> Co-authored-by: Sophia <sophia@unity3d.com>
# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
…cale, Dirt Texture and Dirt Intensity
# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
ernestasKupciunas
approved these changes
Jan 5, 2022
ernestasKupciunas
left a comment
ernestasKupciunas
left a comment
Contributor
There was a problem hiding this comment.
Looks good. The changes work as intended.
My only concern is should the new settings be hidden under the Additional Properties @ellioman?
Other than that, I see no problems with this PR.
Tested using:
2022.1.0b1.2470
Revision: 2022.1/staging ea0f0219deed
Built: Mon, 06 Dec 2021 16:05:05 GMT
Tested platforms:
MacBook Pro (16-inch, 2021), CPU: Apple M1 Max, Memory: 64 GB, macOS: Monterey 12.0 - Metal
iPhone 13Pro Max, SoC: A15, iOS: 15.0.1 - Metal
iPad Air3, SoC: A12, iOS: 13.2.3 - Metal
Samsung Galaxy Z Fold2 5G, 10, Snapdragon 865 SM8250, Adreno 650 - Vulkan and Gles3
OnePlus Nord, 10, Snapdragon 765G SM7250-AB, Adreno 620 - Vulkan and Gles3
I don't have a Windows machine at home.
Also, in addition, I was running this Yamato test. It's an automated URP template scene, which runs on additional Android, Mac, Windows, iOS, and Linux devices. Yamato test link
# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md
# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # com.unity.render-pipelines.universal/Documentation~/Images/Inspectors/Bloom.png
ellioman
added a commit
that referenced
this pull request
Jan 29, 2022
ellioman
added a commit
that referenced
this pull request
Jan 29, 2022
ellioman
changed the title
ellioman
changed the title
ellioman
changed the title
This was referenced Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Jira: URP-964
Users have been asking for more controls for Bloom quality and cost.
This PR addresses that by adding two options to the Bloom volume override:
We also deprecate the
skipIterationsoption asmaxIterationsreplaces it.Before
After
Testing status
What has been tested
What needs testing
Automatic Testing
Test scene 100_BloomHDR has been improved so that it uses the two new settings.
Additionally the Dirt Texture & Intensity has been enabled to make sure it tests that as well, which it did not do before.
Before
After