{{ message }}
[2022.1] Fixed "skip iterations" issue on Bloom#7175
Merged
Conversation
pbbastian
changed the title
ellioman
approved these changes
Feb 17, 2022
phi-lira
approved these changes
Feb 18, 2022
simon-engelbrecht-soerensen
approved these changes
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
The "Skip Iterations" option on Bloom can cause the effect to not run at all due to the mip count being clamped too low. This causes the effect to never output anything in the bloom texture, thus ending up with whatever was in it when GetTemporaryRT returned it. But the rest of the pipeline still expects the bloom texture to contain valid data, and since GetTemporaryRT re-uses textures the contents would drastically change per frame.
On
masterthis is fixed by #6369. We don't want to backport the new options, so instead we do this minimal fix.Testing status
Verified bug locally by setting "Skip Iterations" too high, and then getting the scene view to render some frames while not in play mode.