{{ message }}
BatchRendererGroup Test Projects Automation#6276
Merged
Merged
Conversation
…nity-Technologies/Graphics into hybrid/BRGTestProject_Automate
…nity-Technologies/Graphics into hybrid/BRGTestProject_Automate
…nity-Technologies/Graphics into hybrid/BRGTestProject_Automate
# Conflicts: # TestProjects/BatchRendererGroup_HDRP/Assets/SampleScenes/BRGGameObjects/Lit.mat # TestProjects/BatchRendererGroup_HDRP/Assets/SampleScenes/BRGGameObjects/Lit.mat.meta # TestProjects/BatchRendererGroup_HDRP/Assets/SampleScenes/BRGGameObjects/LitTessellation.mat # TestProjects/BatchRendererGroup_HDRP/Assets/SampleScenes/BRGGameObjects/LitTessellation.mat.meta # TestProjects/BatchRendererGroup_HDRP/Assets/SampleScenes/BRGGameObjects/TestMaterial1.mat # TestProjects/BatchRendererGroup_HDRP/Assets/SampleScenes/BRGGameObjects/TestMaterial1.mat.meta # TestProjects/BatchRendererGroup_HDRP/Assets/SampleScenes/BRGGameObjects/TestMaterial2.mat # TestProjects/BatchRendererGroup_HDRP/Assets/SampleScenes/BRGGameObjects/TestMaterial2.mat.meta # TestProjects/BatchRendererGroup_HDRP/Assets/SampleScenes/BRGGameObjects/Unlit.mat # TestProjects/BatchRendererGroup_HDRP/Assets/SampleScenes/BRGGameObjects/Unlit.mat.meta # TestProjects/BatchRendererGroup_HDRP/ProjectSettings/SceneTemplateSettings.json # TestProjects/HDRP_HybridTests/Assets/SampleScenes/BRGGameObjects/TestMaterial1.mat # TestProjects/HDRP_HybridTests/Assets/SampleScenes/BRGGameObjects/TestMaterial1.mat.meta # TestProjects/HDRP_HybridTests/Assets/SampleScenes/BRGGameObjects/TestMaterial2.mat # TestProjects/HDRP_HybridTests/Assets/SampleScenes/BRGGameObjects/TestMaterial2.mat.meta
kivistikliis
approved these changes
Nov 18, 2021
kivistikliis
left a comment
kivistikliis
left a comment
Contributor
There was a problem hiding this comment.
The .yml side looks good to me!
theopnv
suggested changes
Nov 18, 2021
Contributor
There was a problem hiding this comment.
We can remove line 25 and 32 of the .repoconfig file, as these test folders were renamed https://github.com/Unity-Technologies/Graphics/blob/hybrid/BRGTestProject_Automate/.repoconfig#L25. No need to add the BatchRenderer projects to this file, that way they won't be excluded from the formatting checks (and will comply to unity rules :))
Thanks for the PR!
theopnv
approved these changes
Nov 18, 2021
Verasl
pushed a commit
that referenced
this pull request
Nov 18, 2021
* update reference images * Update HDRP failing test reference images * Add HDRP Linux Vulkan test images * Rename UniversalHybridTest to BatchRendererGroup_URP * Move vulkan win ref images to None folder * Rename HDRP_HybridTests to BatchRenderGroup_HDRP * replace hybrid with BRG and add to nightly * Fix HDRP project name type * fix typo * Add .meta files of added reference images * remove playmode_xr * Update RenderBRG.cs scripts from hrnext-bugfix * Update BrgGameojbects hdrp reference images after master merge * Add vulkan to HDRP brg windows * use gpu for build, remove osx from ci * apply patch from the [Yamato] Formatting job * add BRG to nightly [skip ci] * remove the hybrid projects from repoconfig Co-authored-by: MingWai Chan <mingwai@unity3d.com> Co-authored-by: Tomas Kiniulis <tomas.kiniulis@unity3d.com> Co-authored-by: Sophia <sophia@unity3d.com>
ellioman
added a commit
that referenced
this pull request
Jan 28, 2022
* URP quality improvements (#6090) * "Add Renderer Feature" menu now uses the same menu as "Volume Overrides" * Universal Renderer help URL * Add page hash to help URL helper * Allow renderer features to use HelpURLAttribute and add it for SSAO, Decal, and Render Objects * Remove Name input for SSAO and Screen Space Shadows * Fix help URL for URP asset * Update change log * Fix change log * Remove `Attribute` suffix from attribute usage * Add docs for FilterWindow.Show * Move GetHelpURL to DocumentationUtils * Improve TryGetHelpURL interface * Upgrade test materials and assets for premultiplied blend parity. (#6326) * Upgraded Runtime/Materials/*.mat files. * Foundation CommonAssets/ *.mat files upgrade. * Foundation Scenes/ .mat files upgrade. * Foundation Scenes/ .renderTexture files upgrade. * Lighting CommonAssets/ .mat upgrade. * Lighting EditMode Assets .mat files upgrade. * Lighting Scenes/ .mat files upgrade. * Lighting Scenes/ .renderTexture files upgrade. * Terrain CommonAssets/ .mat files upgrade. * Terrain Scenes/ .mat files upgrade. * PostProcessing CommonAssets/ .mat files upgrade. * PostProcessing Scenes/ .mat files upgrade. * Making intermediate render textures scale with the RenderScale setting when a camera renders to a texture (#6274) * Fix API is in the wrong state issue (#6331) * BatchRendererGroup Test Projects Automation (#6276) * update reference images * Update HDRP failing test reference images * Add HDRP Linux Vulkan test images * Rename UniversalHybridTest to BatchRendererGroup_URP * Move vulkan win ref images to None folder * Rename HDRP_HybridTests to BatchRenderGroup_HDRP * replace hybrid with BRG and add to nightly * Fix HDRP project name type * fix typo * Add .meta files of added reference images * remove playmode_xr * Update RenderBRG.cs scripts from hrnext-bugfix * Update BrgGameojbects hdrp reference images after master merge * Add vulkan to HDRP brg windows * use gpu for build, remove osx from ci * apply patch from the [Yamato] Formatting job * add BRG to nightly [skip ci] * remove the hybrid projects from repoconfig Co-authored-by: MingWai Chan <mingwai@unity3d.com> Co-authored-by: Tomas Kiniulis <tomas.kiniulis@unity3d.com> Co-authored-by: Sophia <sophia@unity3d.com> * Tweaked bloom quality options * made new settings additional * Updated docs * Improving the Bloom Test scene so that it tests Max Iterations, Downscale, Dirt Texture and Dirt Intensity * Renaming the Downscale enum to BloomDownscaleMode * Deprecating the skipIterations variable * Changelog * Changelog * Updating bloom reference image for Android GLES3 Co-authored-by: Peter Bay Bastian <pbbastian@users.noreply.github.com> Co-authored-by: Erik Hakala <59870743+eh-unity@users.noreply.github.com> Co-authored-by: Théo Penavaire <theo-pnv@users.noreply.github.com> Co-authored-by: mingwai <cinight@users.noreply.github.com> Co-authored-by: MingWai Chan <mingwai@unity3d.com> Co-authored-by: Tomas Kiniulis <tomas.kiniulis@unity3d.com> Co-authored-by: Sophia <sophia@unity3d.com> Co-authored-by: Andrem <andrem@unity3d.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Rename BatchRendererGroup projects to reduce confusion as they do not rely on DOTS.
Automate the BatchRendererGroup projects so that they can run nightly or put in Graphics ABV.
What has changed
UniversalHybridTestandHDRP_HybridTeststoBatchRendererGroup_URPandBatchRendererGroup_HDRPTesting status
Me and @TomasKiniulis ran tests on Yamato with existing CIs to prove the tests are working.
Win & Linux are green. Mac Metal failed due to some instabilities.
Therefore we can add Win & Linux to nightly / ABV first.
BatchRendererGroup_URP
Universal_BatchRendererGroup_trunk - green✅
BatchRendererGroup_HDRP
HDRP_BatchRendererGroup_trunk - green ✅
Comment to reviewers
There are only test projects and related yml file changes.