iframe-proxy

Avogar · 2026-04-02T16:32:33Z

Changelog category (leave one):

Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix possible logical error during reading Map subcolumns. Closes #100769. Closes #101336

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)

Version info

Merged into: 26.4.1.748
Backported to: 26.3.6.5

clickhouse-gh · 2026-04-02T16:33:12Z

Workflow [PR], commit [6bae80a]

Summary: ❌

job_name	test_name	status	info
Stateless tests (arm_binary, parallel)		failure
	04092_tcp_settings_parse_error_closes_connection	FAIL	cidb
Integration tests (amd_asan_ubsan, db disk, old analyzer, 1/6)		failure
	test_database_iceberg_nessie_catalog/test.py::test_select	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_tables_with_same_location	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_timestamps	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_insert	FAIL	cidb
Integration tests (amd_asan_ubsan, db disk, old analyzer, 6/6)		failure
	test_database_iceberg_lakekeeper_catalog/test.py::test_select	FAIL	cidb
	test_database_iceberg_lakekeeper_catalog/test.py::test_tables_with_same_location	FAIL	cidb
Integration tests (amd_binary, 3/5)		failure
	test_database_iceberg_lakekeeper_catalog/test.py::test_select	FAIL	cidb
	test_database_iceberg_lakekeeper_catalog/test.py::test_tables_with_same_location	FAIL	cidb
Integration tests (amd_binary, 4/5)		failure
	test_database_iceberg_nessie_catalog/test.py::test_select	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_tables_with_same_location	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_timestamps	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_insert	FAIL	cidb
Integration tests (arm_binary, distributed plan, 1/4)		failure
	test_database_iceberg_nessie_catalog/test.py::test_select	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_tables_with_same_location	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_timestamps	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_insert	FAIL	cidb
Integration tests (arm_binary, distributed plan, 4/4)		failure
	test_database_iceberg_lakekeeper_catalog/test.py::test_select	FAIL	cidb
	test_database_iceberg_lakekeeper_catalog/test.py::test_tables_with_same_location	FAIL	cidb
Integration tests (amd_tsan, 1/6)		failure
	test_database_iceberg_nessie_catalog/test.py::test_select	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_tables_with_same_location	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_timestamps	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_insert	FAIL	cidb
Integration tests (amd_tsan, 6/6)		failure
	test_database_iceberg_lakekeeper_catalog/test.py::test_select	FAIL	cidb
	test_database_iceberg_lakekeeper_catalog/test.py::test_tables_with_same_location	FAIL	cidb
Integration tests (amd_msan, 1/6)		failure
	test_database_iceberg_nessie_catalog/test.py::test_select	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_tables_with_same_location	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_timestamps	FAIL	cidb
	test_database_iceberg_nessie_catalog/test.py::test_insert	FAIL	cidb

AI Review

Summary

This PR fixes a real correctness issue in SerializationMapKeyValue::deserializeBinaryBulkWithMultipleStreams for Map subcolumn reads by always enabling insert_only_rows_in_current_range_from_substreams_cache in the temporary nested-column path, and adds a focused stateless regression test (04076_map_key_value_subcolumn_cache_bug.sql) that reproduces the multi-range read scenario. I did not find blocker- or major-level correctness, safety, concurrency, performance, or compliance issues in the proposed change.

ClickHouse Rules

Item	Status	Notes
Deletion logging	➖
Serialization versioning	➖
Core-area scrutiny	✅
No test removal	✅
Experimental gate	➖
No magic constants	✅
Backward compatibility	✅
`SettingsChangesHistory.cpp`	➖
PR metadata quality	✅
Safe rollout	✅
Compilation time	✅
No large/binary files	✅

Final Verdict

Status: ✅ Approve

alexey-milovidov · 2026-04-07T00:29:21Z

The Stress test (arm_msan) failure is fixed by #101239, which should be merged first. After it is merged, please update the branch to include the fix.

…p-subcolumn-bug

clickhouse-gh · 2026-04-09T17:32:25Z

LLVM Coverage Report

Metric	Baseline	Current	Δ
Lines	84.00%	84.00%	+0.00%
Functions	90.90%	90.90%	+0.00%
Branches	76.50%	76.50%	+0.00%

Changed lines: 100.00% (7/7) · Uncovered code

Full report · Diff report

alexey-milovidov · 2026-04-09T17:56:11Z

The failures look related.

Upd: they aren't.

alexey-milovidov · 2026-04-09T20:49:58Z

Except Iceberg failures - they are likely due to Docker.

alexey-milovidov · 2026-04-09T21:03:11Z

Checked the test 04092_tcp_settings_parse_error_closes_connection it was reverted in master.

alexey-milovidov · 2026-04-09T21:26:35Z

…ap subcolumns

Backport #101641 to 26.3: Fix possible logical error during reading Map subcolumns

Fix possible logical error during reading Map subcolumns

c7e45f9

Avogar added the v26.3-must-backport label Apr 2, 2026

clickhouse-gh Bot added the pr-bugfix Pull request with bugfix, not backported by default label Apr 2, 2026

antaljanosbenjamin approved these changes Apr 2, 2026

View reviewed changes

antaljanosbenjamin self-assigned this Apr 2, 2026

Merge branch 'master' into fix-map-subcolumn-bug

6abb9e1

Avogar mentioned this pull request Apr 9, 2026

Fix LOGICAL_ERROR in adjustLastGranule by clamping MergeTreeReaderWide::readRows #102191

Closed

1 task

Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-ma…

6bae80a

…p-subcolumn-bug

alexey-milovidov mentioned this pull request Apr 9, 2026

Add test for MergeTreeReaderWide wide Map subcolumn over-read #102292

Closed

1 task

alexey-milovidov self-assigned this Apr 9, 2026

alexey-milovidov merged commit fb1aa42 into master Apr 9, 2026
146 of 163 checks passed

alexey-milovidov deleted the fix-map-subcolumn-bug branch April 9, 2026 21:03

robot-clickhouse-ci-1 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Apr 9, 2026

robot-clickhouse mentioned this pull request Apr 9, 2026

Cherry pick #101641 to 26.3: Fix possible logical error during reading Map subcolumns #102295

Merged

robot-clickhouse added a commit that referenced this pull request Apr 9, 2026

Backport #101641 to 26.3: Fix possible logical error during reading M…

f728b87

…ap subcolumns

robot-clickhouse mentioned this pull request Apr 9, 2026

Backport #101641 to 26.3: Fix possible logical error during reading Map subcolumns #102296

Merged

robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 9, 2026

robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Apr 9, 2026

clickhouse-gh Bot added a commit that referenced this pull request Apr 10, 2026

Merge pull request #102296 from ClickHouse/backport/26.3/101641

76a4a77

Backport #101641 to 26.3: Fix possible logical error during reading Map subcolumns

clickgapai mentioned this pull request Jun 19, 2026

Map element access (map['key']) re-reads the whole map column once per distinct key — O(N) I/O for N keys #107912

Closed

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix possible logical error during reading Map subcolumns#101641

Fix possible logical error during reading Map subcolumns#101641
alexey-milovidov merged 3 commits into
masterfrom
fix-map-subcolumn-bug

Avogar commented Apr 2, 2026 •

edited by robot-clickhouse

Loading

Uh oh!

clickhouse-gh Bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

alexey-milovidov commented Apr 7, 2026

Uh oh!

clickhouse-gh Bot commented Apr 9, 2026

Uh oh!

alexey-milovidov commented Apr 9, 2026 •

edited

Loading

Uh oh!

alexey-milovidov commented Apr 9, 2026

Uh oh!

alexey-milovidov commented Apr 9, 2026

Uh oh!

Uh oh!

alexey-milovidov commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

Avogar commented Apr 2, 2026 • edited by robot-clickhouse Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Documentation entry for user-facing changes

Version info

Uh oh!

clickhouse-gh Bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

AI Review

Summary

ClickHouse Rules

Final Verdict

Uh oh!

alexey-milovidov commented Apr 7, 2026

Uh oh!

clickhouse-gh Bot commented Apr 9, 2026

LLVM Coverage Report

Uh oh!

alexey-milovidov commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexey-milovidov commented Apr 9, 2026

Uh oh!

alexey-milovidov commented Apr 9, 2026

Uh oh!

Uh oh!

alexey-milovidov commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Avogar commented Apr 2, 2026 •

edited by robot-clickhouse

Loading

clickhouse-gh Bot commented Apr 2, 2026 •

edited

Loading

alexey-milovidov commented Apr 9, 2026 •

edited

Loading