{{ message }}
Fix column resize in play.html after web component refactoring#101295
Merged
Conversation
Shadow DOM does not inherit `box-sizing: border-box` from the outer document. When `_changeTableLayout` reads `offsetWidth` (which includes content + padding + border) and sets it as `style.width`, the default `content-box` model interprets that as content-only width, adding padding and border on top. This makes every column wider, shifting the table to the right. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
clickhouse-gh
Bot
added
the
pr-improvement
Member
Author
|
The Stress test (arm_msan) failure is fixed by #101239, which should be merged first. After it is merged, please update the branch to include the fix. |
Member
Author
|
The fix for tests on Azure: #100980 |
Member
Author
|
The |
Member
Author
|
UBSan issue is fixed here: #100086 |
Member
Author
|
@pamarcos I've found a bug on your "after" screenshot. The number |
Member
Author
robot-clickhouse
added
pr-must-backport-synced
This was referenced Apr 10, 2026
Merged
robot-ch-test-poll2
added
the
pr-backports-created
alexey-milovidov
added a commit
that referenced
this pull request
Apr 10, 2026
Backport #101295 to 26.3: Fix column resize in play.html after web component refactoring
alexey-milovidov
added a commit
that referenced
this pull request
Apr 10, 2026
Backport #101295 to 26.2: Fix column resize in play.html after web component refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shadow DOM does not inherit
box-sizing: border-boxfrom the outer document. When_changeTableLayoutreadsoffsetWidth(which includes content + padding + border) and sets it asstyle.width, the defaultcontent-boxmodel interprets that as content-only width, adding padding and border on top. This makes every column wider, shifting the table to the right and visibly widening the row-number column.The fix adds
box-sizing: border-boxto the shadow DOM styles ofQueryResultElement.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix column resize in play.html web UI after the result table was refactored into a web component.
Documentation entry for user-facing changes
Version info
26.4.1.77526.3.6.7,26.2.10.10