Fix non-deterministic Map ordering in test 03546_json_input_output_map_as_array by alexey-milovidov · Pull Request #101892 · ClickHouse/ClickHouse · GitHub
Skip to content

Fix non-deterministic Map ordering in test 03546_json_input_output_map_as_array#101892

Merged
Avogar merged 4 commits into
masterfrom
fix/03546-json-map-ordering
Apr 10, 2026
Merged

Fix non-deterministic Map ordering in test 03546_json_input_output_map_as_array#101892
Avogar merged 4 commits into
masterfrom
fix/03546-json-map-ordering

Conversation

@alexey-milovidov

@alexey-milovidov alexey-milovidov commented Apr 6, 2026

Copy link
Copy Markdown
Member

Fix flaky test 03546_json_input_output_map_as_array which fails because Map(Tuple(UInt32, UInt32), Int32) has non-deterministic key ordering that varies with random CI settings. Use mapSort to ensure deterministic output.

Observed in #92579

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Version info

  • Merged into: 26.4.1.805

…ap_as_array`

Use `mapSort` to ensure deterministic key ordering in JSON output for
Map columns with Tuple keys, which have non-deterministic iteration order
that varies with random CI settings.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@clickhouse-gh

clickhouse-gh Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

@clickhouse-gh clickhouse-gh Bot added the pr-ci label Apr 6, 2026

@alexey-milovidov alexey-milovidov left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@alexey-milovidov

Copy link
Copy Markdown
Member Author

The Stress test (arm_msan) failure is fixed by #101239, which should be merged first. After it is merged, please update the branch to include the fix.

@Avogar Avogar self-assigned this Apr 7, 2026
@alexey-milovidov

Copy link
Copy Markdown
Member Author

#101952

@alexey-milovidov

Copy link
Copy Markdown
Member Author

The test 02859_replicated_db_name_zookeeper is fixed in #101952

@alexey-milovidov

Copy link
Copy Markdown
Member Author

The Can't adjust last granule error in CI is a known issue. The fix is in #101641

@Avogar Avogar added this pull request to the merge queue Apr 10, 2026
@Avogar

Avogar commented Apr 10, 2026

Copy link
Copy Markdown
Member

Merged via the queue into master with commit c6ccbbd Apr 10, 2026
161 of 163 checks passed
@Avogar Avogar deleted the fix/03546-json-map-ordering branch April 10, 2026 14:18
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants