{{ message }}
Include autoMergeRequest info in gh pr commands#7311
Closed
mjpieters wants to merge 4 commits into
Closed
Conversation
Consolidate the GraphQL page-fetching loops into one method, with each variant providing a struct to handle the different response types.
Because the API doesn't support filtering by autoMergeRequest status, the API responses are filtered locally.
mislav
reviewed
Apr 25, 2023
mislav
left a comment
mislav
left a comment
Contributor
There was a problem hiding this comment.
There is a lot of goodies in this PR so far, so thank you for that, but I fear that it's quickly becoming too large for its original intended purpose. I suggest splitting each added feature into separate PRs so that they are easier to comprehend and to review, and that they're less risky to apply.
For instance, adding autoMergeRequest information to PRs JSON fields could be one PR, but extending the output of gh pr status with this information should be another. While doing each change, please mind the size of the diff. Too large a diff can often be a code smell and indicate that maybe a simpler approach could be taken. Thanks!
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
Fixes #7309