{{ message }}
Add --auto-merge filtering to gh pr list#7387
Closed
mjpieters wants to merge 2 commits into
Closed
Conversation
cliAutomation
added
the
external
4 tasks
Contributor
Author
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mjpieters
force-pushed
the
auto_merge_gh_pr_list
branch
3 times, most recently
from
c460be3 to
3503ef8
Compare
Consolidate the GraphQL page-fetching loops into one method, with each variant providing a struct to handle the different response types.
Because the API doesn't support filtering by autoMergeRequest status, the API responses are filtered locally.
mjpieters
force-pushed
the
auto_merge_gh_pr_list
branch
from
3503ef8 to
05ce139
Compare
mislav
reviewed
May 10, 2023
Contributor
There was a problem hiding this comment.
Hmm, I must admit I'm not convinced of the utility of client-side filtering in this case. If a server-side filter does not exist for this, then I would rather opt to not expose this kind of filtering in the list command.
You have already exposed --json autoMergeRequest, so I would vote in favor of consuming that manually.
Others: thoughts?
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a series for issue #7309, adding auto-merge status support to PR commands
Add the ability to filter the
gh pr listPRs on their auto-merge status. There is no server-side support for this, so entries are filtered when retrieving the list of PRs from GraphQL.Because the list now is (further) filtered on the client side, the total number of PRs after filtering can't be known exactly until you fetch all pages, which would be inefficient and wasteful, so instead the total is marked as an upper bound and the text changes from Showing MATCHED of TOTAL to Showing MATCHED of up to TOTAL unless the last page was reached during local filtering.
$ gh pr list --auto-merge disabled Showing 30 of 35 pull requests in cli/cli that match your search ...There are two commits here; the first commit refactors the
pr/list/http.gocode to consolidate the GraphQL paged-result handling for the twoPullRequestListandPullRequestSearchfunctions into a singlefetchPullRequests()function that can handle GraphQL paging for either. This makes it then far easier to add client-side filtering to this single function rather that having to duplicate the effort.