iframe-proxy

chandra-siri · 2026-01-26T11:34:47Z

Expose DELETE_OBJECT in AsyncGrpcClient

gemini-code-assist · 2026-01-26T11:35:04Z

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the foundational code for exposing metadata operations within the AsyncGrpcClient for Google Cloud Storage. The primary addition is an asynchronous delete_object method, which enables direct gRPC-based object deletion, supporting conditional operations based on object generation and metageneration. This change enhances the client's capability to interact with Google Cloud Storage at a lower level, providing more granular control over object lifecycle management.

Highlights

New delete_object method: Implemented an asynchronous delete_object method in AsyncGrpcClient to support object deletion with various conditional parameters like generation, if_generation_match, and if_metageneration_match.
System Test for Deletion: Added a system test (test_delete_object_using_grpc_client) to validate the functionality of the new delete_object method, including verification of object removal and handling of NotFound exceptions.
Unit Test for Request Construction: Introduced a dedicated unit test (TestDeleteObject.test_delete_object) to ensure the correct construction of DeleteObjectRequest and proper invocation of the underlying gRPC client.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request introduces an async_grpc_client with a delete_object method and includes corresponding unit and system tests. The delete_object method correctly constructs the gRPC request. However, there are some inconsistencies and potential issues in the system test's usage of the new method and a minor documentation detail in the async_grpc_client's docstring. The example usage in async_grpc_client.py also has a minor issue with error re-raising.

gemini-code-assist · 2026-01-26T11:36:59Z

+    """
+    Test that a new writer when specifies `None` overrides the existing object.


The docstring for test_delete_object_using_grpc_client is incorrect. It describes a test for overriding an existing object, not for deleting an object. Please update it to accurately reflect the purpose of this test.

Suggested change

"""

Test that a new writer when specifies `None` overrides the existing object.

"""

Test that `delete_object` using the gRPC client successfully deletes an object.

"""

…data_ops_in_grpc

…torage into metadata_ops_in_grpc

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.2-0.20251119154421-36c3e21ad3ac Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91 <details><summary>google-cloud-storage: 3.9.0</summary> ## [3.9.0](v3.8.0...v3.9.0) (2026-02-02) ### Features * update generation for MRD (#1730) ([08bc708](08bc7082)) * add get_object method for async grpc client (#1735) ([0e5ec29](0e5ec29b)) * Add micro-benchmarks for reads comparing standard (regional) vs rapid (zonal) buckets. (#1697) ([1917649](1917649f)) * Add support for opening via `write_handle` and fix `write_handle` type (#1715) ([2bc15fa](2bc15fa5)) * add samples for appendable objects writes and reads ([2e1a1eb](2e1a1eb5)) * add samples for appendable objects writes and reads (#1705) ([2e1a1eb](2e1a1eb5)) * add context manager to mrd (#1724) ([5ac2808](5ac2808a)) * Move Zonal Buckets features of `_experimental` (#1728) ([74c9ecc](74c9ecc5)) * add default user agent for grpc (#1726) ([7b31946](7b319469)) * expose finalized_time in blob.py applicable for GET_OBJECT in ZB (#1719) ([8e21a7f](8e21a7fe)) * expose `DELETE_OBJECT` in `AsyncGrpcClient` (#1718) ([c8dd7a0](c8dd7a0b)) * send `user_agent` to grpc channel (#1712) ([cdb2486](cdb2486b)) * integrate writes strategy and appendable object writer (#1695) ([dbd162b](dbd162b3)) * Add micro-benchmarks for writes comparing standard (regional) vs rapid (zonal) buckets. (#1707) ([dbe9d8b](dbe9d8b8)) * add support for `generation=0` to avoid overwriting existing objects and add `is_stream_open` support (#1709) ([ea0f5bf](ea0f5bf8)) * add support for `generation=0` to prevent overwriting existing objects ([ea0f5bf](ea0f5bf8)) * add `is_stream_open` property to AsyncAppendableObjectWriter for stream status check ([ea0f5bf](ea0f5bf8)) ### Bug Fixes * receive eof while closing reads stream (#1733) ([2ef6339](2ef63396)) * update write handle on every recv() (#1716) ([5d9fafe](5d9fafe1)) * implement requests_done method to signal end of requests in async streams. Gracefully close streams. (#1700) ([6c16079](6c160794)) * implement requests_done method to signal end of requests in async streams. Gracefully close streams. ([6c16079](6c160794)) * instance grpc client once per process in benchmarks (#1725) ([721ea2d](721ea2dd)) * Fix formatting in setup.py dependencies list (#1713) ([cc4831d](cc4831d7)) * Change contructors of MRD and AAOW AsyncGrpcClient.grpc_client to AsyncGrpcClient (#1727) ([e730bf5](e730bf50)) </details>

init code for exposing metadata ops into grpcCient

59b7b26

product-auto-label Bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Jan 26, 2026

gemini-code-assist Bot reviewed Jan 26, 2026

View reviewed changes

chandra-siri added 4 commits January 28, 2026 19:44

Merge branch 'main' into metadata_ops_in_grpc

9b66296

Merge branch 'main' of github.com:googleapis/python-storage into meta…

243fda9

…data_ops_in_grpc

Merge branch 'metadata_ops_in_grpc' of github.com:googleapis/python-s…

3a60452

…torage into metadata_ops_in_grpc

add lint & formatting changes

c0cdd26

chandra-siri changed the title ~~init code for exposing metadata ops into grpcCient~~ Expose DELETE_OBJECT in AsyncGrpcClient Jan 29, 2026

chandra-siri marked this pull request as ready for review January 29, 2026 13:11

chandra-siri requested review from a team January 29, 2026 13:11

chandra-siri requested a review from a team as a code owner January 29, 2026 13:11

chandra-siri changed the title ~~Expose DELETE_OBJECT in AsyncGrpcClient~~ feat: expose DELETE_OBJECT in AsyncGrpcClient Jan 29, 2026

chandra-siri assigned Pulkit0110, ankitaluthra1 and suni72 Jan 29, 2026

Pulkit0110 approved these changes Jan 30, 2026

View reviewed changes

chandra-siri merged commit c8dd7a0 into main Jan 30, 2026
18 checks passed

chandra-siri deleted the metadata_ops_in_grpc branch January 30, 2026 06:39

release-please Bot mentioned this pull request Jan 30, 2026

chore(main): release 4.0.0 #1708

Closed

chandra-siri mentioned this pull request Feb 2, 2026

chore: librarian release pull request: 20260202T123858Z #1736

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: expose `DELETE_OBJECT` in `AsyncGrpcClient`#1718

feat: expose `DELETE_OBJECT` in `AsyncGrpcClient`#1718
chandra-siri merged 5 commits into
mainfrom
metadata_ops_in_grpc

chandra-siri commented Jan 26, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Jan 26, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

gemini-code-assist Bot Jan 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		"""
		Test that a new writer when specifies `None` overrides the existing object.

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

chandra-siri commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Jan 26, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist Bot Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chandra-siri commented Jan 26, 2026 •

edited

Loading