iframe-proxy

Pulkit0110 · 2025-12-24T05:59:40Z

Integrate all the components required for bidi writes retries

gemini-code-assist · 2025-12-24T06:00:16Z

Summary of Changes

Hello @Pulkit0110, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the robustness of asynchronous object operations in Google Cloud Storage by implementing a sophisticated retry and resumption system for bidirectional streaming. It introduces dedicated strategies to manage the state of ongoing read and write operations, automatically re-establishing streams and continuing data transfer from the last known good state in the event of transient network issues or server-side redirects. This ensures that applications using these experimental APIs can handle intermittent failures gracefully, leading to more reliable data transfers.

Highlights

Bidirectional Stream Retry Mechanism: Introduced a comprehensive retry mechanism for asynchronous bidirectional (bidi) streaming operations, specifically for object reads and writes, to enhance resilience against transient errors and redirects.
New Retry Strategies and Manager: Implemented a generic _BidiStreamRetryManager and specific _ReadResumptionStrategy and _WriteResumptionStrategy classes to manage the state, generate requests, and recover from failures during bidi stream retries.
Integration into Async Writers/Readers: Refactored AsyncAppendableObjectWriter and AsyncMultiRangeDownloader to integrate the new retry logic, allowing their open, append, and download_ranges methods to automatically handle retries and stream re-establishment.
Error Handling and State Recovery: Added predicates (_is_write_retryable, _is_read_retryable) to identify retryable exceptions and _on_open_error methods to extract routing tokens and handles from redirect errors, enabling intelligent state recovery.
Extensive Testing: Included new conformance tests for bidi reads to validate retry behavior under various fault injection scenarios, alongside new unit tests for the retry manager and both read/write resumption strategies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a significant and well-designed refactoring to integrate retry strategies for bidirectional reads and writes, enhancing the robustness of experimental asyncio features. The abstraction of retry logic into a _BidiStreamRetryManager and specific _WriteResumptionStrategy and _ReadResumptionStrategy classes is a solid architectural choice. The accompanying unit and conformance tests are comprehensive and provide good coverage for the new functionality. My review comments focus on improving error handling by replacing broad except Exception blocks with more specific ones and avoiding print() statements in library code.

…riter

Pulkit0110 · 2026-01-23T09:26:55Z

/gcbrun

Pulkit0110 · 2026-01-27T10:46:27Z

/gcbrun

Pulkit0110 · 2026-01-28T05:12:39Z

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.2-0.20251119154421-36c3e21ad3ac Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91 <details><summary>google-cloud-storage: 3.9.0</summary> ## [3.9.0](v3.8.0...v3.9.0) (2026-02-02) ### Features * update generation for MRD (#1730) ([08bc708](08bc7082)) * add get_object method for async grpc client (#1735) ([0e5ec29](0e5ec29b)) * Add micro-benchmarks for reads comparing standard (regional) vs rapid (zonal) buckets. (#1697) ([1917649](1917649f)) * Add support for opening via `write_handle` and fix `write_handle` type (#1715) ([2bc15fa](2bc15fa5)) * add samples for appendable objects writes and reads ([2e1a1eb](2e1a1eb5)) * add samples for appendable objects writes and reads (#1705) ([2e1a1eb](2e1a1eb5)) * add context manager to mrd (#1724) ([5ac2808](5ac2808a)) * Move Zonal Buckets features of `_experimental` (#1728) ([74c9ecc](74c9ecc5)) * add default user agent for grpc (#1726) ([7b31946](7b319469)) * expose finalized_time in blob.py applicable for GET_OBJECT in ZB (#1719) ([8e21a7f](8e21a7fe)) * expose `DELETE_OBJECT` in `AsyncGrpcClient` (#1718) ([c8dd7a0](c8dd7a0b)) * send `user_agent` to grpc channel (#1712) ([cdb2486](cdb2486b)) * integrate writes strategy and appendable object writer (#1695) ([dbd162b](dbd162b3)) * Add micro-benchmarks for writes comparing standard (regional) vs rapid (zonal) buckets. (#1707) ([dbe9d8b](dbe9d8b8)) * add support for `generation=0` to avoid overwriting existing objects and add `is_stream_open` support (#1709) ([ea0f5bf](ea0f5bf8)) * add support for `generation=0` to prevent overwriting existing objects ([ea0f5bf](ea0f5bf8)) * add `is_stream_open` property to AsyncAppendableObjectWriter for stream status check ([ea0f5bf](ea0f5bf8)) ### Bug Fixes * receive eof while closing reads stream (#1733) ([2ef6339](2ef63396)) * update write handle on every recv() (#1716) ([5d9fafe](5d9fafe1)) * implement requests_done method to signal end of requests in async streams. Gracefully close streams. (#1700) ([6c16079](6c160794)) * implement requests_done method to signal end of requests in async streams. Gracefully close streams. ([6c16079](6c160794)) * instance grpc client once per process in benchmarks (#1725) ([721ea2d](721ea2dd)) * Fix formatting in setup.py dependencies list (#1713) ([cc4831d](cc4831d7)) * Change contructors of MRD and AAOW AsyncGrpcClient.grpc_client to AsyncGrpcClient (#1727) ([e730bf5](e730bf50)) </details>

product-auto-label Bot added size: xl Pull request size is extra large. api: storage Issues related to the googleapis/python-storage API. labels Dec 24, 2025

gemini-code-assist Bot reviewed Dec 24, 2025

View reviewed changes

Pulkit0110 force-pushed the bidi-writes-retry-integrate branch from c3ba20d to 36a02d7 Compare January 2, 2026 10:57

product-auto-label Bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Jan 2, 2026

Pulkit0110 force-pushed the bidi-writes-retry-integrate branch from 36a02d7 to 5d39296 Compare January 13, 2026 06:53

product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 13, 2026

Pulkit0110 marked this pull request as ready for review January 13, 2026 06:59

Pulkit0110 requested review from a team January 13, 2026 06:59

Pulkit0110 requested a review from a team as a code owner January 13, 2026 06:59

blunderbuss-gcf Bot assigned chandra-siri Jan 13, 2026

chandra-siri suggested changes Jan 15, 2026

View reviewed changes

Pulkit0110 force-pushed the bidi-writes-retry-integrate branch from fb9c976 to 8347af2 Compare January 21, 2026 11:35

Pulkit0110 added 13 commits January 23, 2026 06:24

integrate retry logic with the MRD

90a60b8

feat(experimental): add write resumption strategy

0d9f834

address gemini bot comments

6b7b4f3

feat(experimental): integrate writes strategy and appendable object w…

7987c57

…riter

more changes

cf745fc

adding unit tests

3dee18c

adding more unit tests

af9fc7a

fix lint errors

fe3d210

refactor unit tests

ac07610

fix lint errors

1303256

yield requests from generator

97e068e

add debug logs

1945a9b

add more logs

eaac82c

Pulkit0110 added 2 commits January 23, 2026 06:26

remove extra logs

99b20b7

adding more changes

359a23c

Pulkit0110 force-pushed the bidi-writes-retry-integrate branch from 637019e to 359a23c Compare January 23, 2026 06:30

Pulkit0110 added 2 commits January 23, 2026 07:04

minor changes

78088db

resolving comments

c59db11

chandra-siri suggested changes Jan 24, 2026

View reviewed changes

address comments and refactor other files

c0b4d44

chandra-siri previously approved these changes Jan 27, 2026

View reviewed changes

Comment thread tests/unit/asyncio/test_async_appendable_object_writer.py Outdated

remove locks

0b46419

Pulkit0110 dismissed chandra-siri’s stale review via 0b46419 January 27, 2026 10:02

fix lint

d9c6365

chandra-siri approved these changes Jan 27, 2026

View reviewed changes

Pulkit0110 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2026

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2026

Pulkit0110 merged commit dbd162b into googleapis:main Jan 28, 2026
18 of 19 checks passed

release-please Bot mentioned this pull request Jan 22, 2026

chore(main): release 4.0.0 #1708

Closed

This was referenced Jan 29, 2026

chore: librarian release pull request: 20260129T115903Z #1731

Closed

chore: librarian release pull request: 20260202T123858Z #1736

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

Pulkit0110 commented Dec 24, 2025

Uh oh!

gemini-code-assist Bot commented Dec 24, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pulkit0110 commented Jan 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pulkit0110 commented Jan 27, 2026

Uh oh!

Pulkit0110 commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants