feat(ZonalBuckets): add support for `generation=0` to avoid overwriting existing objects and add `is_stream_open` support by chandra-siri · Pull Request #1709 · googleapis/python-storage · GitHub
Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat(ZonalBuckets): add support for generation=0 to avoid overwriting existing objects and add is_stream_open support #1709

Merged
chandra-siri merged 6 commits into
mainfrom
generation_match_and_stream_open
Jan 16, 2026
Merged

feat(ZonalBuckets): add support for generation=0 to avoid overwriting existing objects and add is_stream_open support #1709
chandra-siri merged 6 commits into
mainfrom
generation_match_and_stream_open

Conversation

@chandra-siri

@chandra-siri chandra-siri commented Jan 16, 2026

Copy link
Copy Markdown
Collaborator

feat(ZonalBuckets): add support for generation=0 to prevent overwriting existing objects
feat(ZonalBuckets): add is_stream_open property to AsyncAppendableObjectWriter for stream status check

@chandra-siri chandra-siri requested review from a team January 16, 2026 12:08
@chandra-siri chandra-siri requested a review from a team as a code owner January 16, 2026 12:08
@chandra-siri chandra-siri enabled auto-merge (squash) January 16, 2026 12:08
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Jan 16, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new public property is_stream_open to the AsyncAppendableObjectWriter class. This change improves the class's public API by providing a clear way to check if the underlying stream is open. The tests have been updated accordingly to use this new property, which is good practice. My review includes one suggestion to improve consistency in the test suite.

Comment thread tests/unit/asyncio/test_async_appendable_object_writer.py Outdated
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 16, 2026
@chandra-siri chandra-siri changed the title feat(ZonalBuckets): add is_stream_open property to AsyncAppendableObjectWriter for stream status check feat(ZonalBuckets): add support for generation=0 to avoid overwriting existing objects and add is_stream_open support Jan 16, 2026
@chandra-siri chandra-siri changed the title feat(ZonalBuckets): add support for generation=0 to avoid overwriting existing objects and add is_stream_open support feat(ZonalBuckets): add support for generation=0 to avoid overwriting existing objects and add is_stream_open support Jan 16, 2026
chandra-siri and others added 2 commits January 16, 2026 18:06
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…iter and _AsyncWriteObjectStream

- Updated documentation to clarify behavior when using generation=0 and None.
- Added tests to verify correct handling of object creation and overwriting based on generation settings.
@chandra-siri chandra-siri merged commit ea0f5bf into main Jan 16, 2026
18 checks passed
@chandra-siri chandra-siri deleted the generation_match_and_stream_open branch January 16, 2026 17:54
chandra-siri added a commit that referenced this pull request Feb 2, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v1.0.2-0.20251119154421-36c3e21ad3ac
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91
<details><summary>google-cloud-storage: 3.9.0</summary>

##
[3.9.0](v3.8.0...v3.9.0)
(2026-02-02)

### Features

* update generation for MRD (#1730)
([08bc708](08bc7082))

* add get_object method for async grpc client (#1735)
([0e5ec29](0e5ec29b))

* Add micro-benchmarks for reads comparing standard (regional) vs rapid
(zonal) buckets. (#1697)
([1917649](1917649f))

* Add support for opening via `write_handle` and fix `write_handle` type
(#1715)
([2bc15fa](2bc15fa5))

* add samples for appendable objects writes and reads
([2e1a1eb](2e1a1eb5))

* add samples for appendable objects writes and reads (#1705)
([2e1a1eb](2e1a1eb5))

* add context manager to mrd (#1724)
([5ac2808](5ac2808a))

* Move Zonal Buckets features of `_experimental` (#1728)
([74c9ecc](74c9ecc5))

* add default user agent for grpc (#1726)
([7b31946](7b319469))

* expose finalized_time in blob.py applicable for GET_OBJECT in ZB
(#1719)
([8e21a7f](8e21a7fe))

* expose `DELETE_OBJECT` in `AsyncGrpcClient` (#1718)
([c8dd7a0](c8dd7a0b))

* send `user_agent` to grpc channel (#1712)
([cdb2486](cdb2486b))

* integrate writes strategy and appendable object writer (#1695)
([dbd162b](dbd162b3))

* Add micro-benchmarks for writes comparing standard (regional) vs rapid
(zonal) buckets. (#1707)
([dbe9d8b](dbe9d8b8))

* add support for `generation=0` to avoid overwriting existing objects
and add `is_stream_open` support (#1709)
([ea0f5bf](ea0f5bf8))

* add support for `generation=0` to prevent overwriting existing objects
([ea0f5bf](ea0f5bf8))

* add `is_stream_open` property to AsyncAppendableObjectWriter for
stream status check
([ea0f5bf](ea0f5bf8))

### Bug Fixes

* receive eof while closing reads stream (#1733)
([2ef6339](2ef63396))

* update write handle on every recv() (#1716)
([5d9fafe](5d9fafe1))

* implement requests_done method to signal end of requests in async
streams. Gracefully close streams. (#1700)
([6c16079](6c160794))

* implement requests_done method to signal end of requests in async
streams. Gracefully close streams.
([6c16079](6c160794))

* instance grpc client once per process in benchmarks (#1725)
([721ea2d](721ea2dd))

* Fix formatting in setup.py dependencies list (#1713)
([cc4831d](cc4831d7))

* Change contructors of MRD and AAOW AsyncGrpcClient.grpc_client to
AsyncGrpcClient (#1727)
([e730bf5](e730bf50))

</details>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants