iframe-proxy

chandra-siri · 2026-01-21T18:37:00Z

fix: update write_handle on every recv() from write object stream.

gemini-code-assist · 2026-01-21T18:37:24Z

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the robustness and correctness of asynchronous object writing and reading operations, particularly concerning the management of write_handles. It ensures that these handles are consistently updated during stream interactions, preventing potential issues with stale references. Additionally, the PR refines the type annotations for these handles and significantly enhances the testing framework for asynchronous components, making the system more reliable and easier to maintain.

Highlights

Write Handle Update Logic: Introduced a new utility function update_write_handle_if_exists to ensure that the write_handle attribute of an object is updated after every recv() operation in asynchronous write streams, addressing potential staleness.
Type Hint Refinement: Updated type hints for handle and write_handle across several asynchronous stream classes (e.g., _AsyncAbstractObjectStream, AsyncAppendableObjectWriter, AsyncMultiRangeDownloader, _AsyncReadObjectStream, _AsyncWriteObjectStream) from bytes to Any or more specific _storage_v2.BidiWriteHandle types for improved clarity and type safety.
Asynchronous Test Infrastructure Improvement: Refactored system tests in test_zonal.py to use session-scoped event_loop and grpc_clients fixtures, ensuring gRPC clients are instantiated within the correct event loop context and removing redundant @pytest.mark.asyncio decorators from individual test functions.
Enhanced Error Handling and Testing: Added new unit tests to test_async_write_object_stream.py to cover scenarios like missing persisted_size when opening a stream with a write_handle and explicitly verifying that the write_handle is updated correctly by recv() and requests_done methods.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a fix to update the write_handle on every recv() call, ensuring the most current handle is used. This is achieved by adding a new utility function and applying it across different stream operations. The changes also include updating type hints for handles from bytes to their specific proto types, which improves code clarity and correctness. Additionally, there's a significant and valuable refactoring of the system tests to use session-scoped event loops and gRPC clients, which should improve test performance and stability. I've identified one critical bug in async_write_object_stream.py where an AttributeError could occur when opening a stream with an existing write_handle. A code suggestion to fix this is provided.

I am having trouble creating individual review comments. Click here to see my feedback.

google/cloud/storage/_experimental/asyncio/async_write_object_stream.py (153-181)

When opening a stream with is_open_via_write_handle=True, response.resource is not guaranteed to be populated. Accessing response.resource.generation will raise an AttributeError. The generation number is already known in this case, so it should only be updated from the response when a new stream is created without a handle.

self.generation_number = response.resource.generation should be moved inside the else block that handles the case where is_open_via_write_handle is false.

        if is_open_via_write_handle:
            # Don't use if not response.persisted_size because this will be true
            # if persisted_size==0 (0 is considered "Falsy" in Python)
            if response.persisted_size is None:
                raise ValueError(
                    "Failed to obtain persisted_size after opening the stream via write_handle"
                )
            self.persisted_size = response.persisted_size
        else:
            if not response.resource:
                raise ValueError(
                    "Failed to obtain object resource after opening the stream"
                )
            if not response.resource.generation:
                raise ValueError(
                    "Failed to obtain object generation after opening the stream"
                )
            if not response.resource.size:
                # Appending to a 0 byte appendable object.
                self.persisted_size = 0
            else:
                self.persisted_size = response.resource.size
            self.generation_number = response.resource.generation

        if not response.write_handle:
            raise ValueError("Failed to obtain write_handle after opening the stream")

        self.write_handle = response.write_handle

The merge-base changed after approval.

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.2-0.20251119154421-36c3e21ad3ac Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91 <details><summary>google-cloud-storage: 3.9.0</summary> ## [3.9.0](v3.8.0...v3.9.0) (2026-02-02) ### Features * update generation for MRD (#1730) ([08bc708](08bc7082)) * add get_object method for async grpc client (#1735) ([0e5ec29](0e5ec29b)) * Add micro-benchmarks for reads comparing standard (regional) vs rapid (zonal) buckets. (#1697) ([1917649](1917649f)) * Add support for opening via `write_handle` and fix `write_handle` type (#1715) ([2bc15fa](2bc15fa5)) * add samples for appendable objects writes and reads ([2e1a1eb](2e1a1eb5)) * add samples for appendable objects writes and reads (#1705) ([2e1a1eb](2e1a1eb5)) * add context manager to mrd (#1724) ([5ac2808](5ac2808a)) * Move Zonal Buckets features of `_experimental` (#1728) ([74c9ecc](74c9ecc5)) * add default user agent for grpc (#1726) ([7b31946](7b319469)) * expose finalized_time in blob.py applicable for GET_OBJECT in ZB (#1719) ([8e21a7f](8e21a7fe)) * expose `DELETE_OBJECT` in `AsyncGrpcClient` (#1718) ([c8dd7a0](c8dd7a0b)) * send `user_agent` to grpc channel (#1712) ([cdb2486](cdb2486b)) * integrate writes strategy and appendable object writer (#1695) ([dbd162b](dbd162b3)) * Add micro-benchmarks for writes comparing standard (regional) vs rapid (zonal) buckets. (#1707) ([dbe9d8b](dbe9d8b8)) * add support for `generation=0` to avoid overwriting existing objects and add `is_stream_open` support (#1709) ([ea0f5bf](ea0f5bf8)) * add support for `generation=0` to prevent overwriting existing objects ([ea0f5bf](ea0f5bf8)) * add `is_stream_open` property to AsyncAppendableObjectWriter for stream status check ([ea0f5bf](ea0f5bf8)) ### Bug Fixes * receive eof while closing reads stream (#1733) ([2ef6339](2ef63396)) * update write handle on every recv() (#1716) ([5d9fafe](5d9fafe1)) * implement requests_done method to signal end of requests in async streams. Gracefully close streams. (#1700) ([6c16079](6c160794)) * implement requests_done method to signal end of requests in async streams. Gracefully close streams. ([6c16079](6c160794)) * instance grpc client once per process in benchmarks (#1725) ([721ea2d](721ea2dd)) * Fix formatting in setup.py dependencies list (#1713) ([cc4831d](cc4831d7)) * Change contructors of MRD and AAOW AsyncGrpcClient.grpc_client to AsyncGrpcClient (#1727) ([e730bf5](e730bf50)) </details>

chandra-siri added 7 commits January 21, 2026 14:48

chore: move system tests to single event loop

4ab7877

open with read handle works only in direct_path

4439039

remove unwated file

190498a

Merge branch 'main' into single_event_loop

93d64e0

fix: rectify handle type

35a9e05

feat: add support for opening via write handle

9bc6375

fix: update write handle on every recv()

959519a

chandra-siri requested review from a team January 21, 2026 18:37

chandra-siri requested a review from a team as a code owner January 21, 2026 18:37

product-auto-label Bot added size: xl Pull request size is extra large. api: storage Issues related to the googleapis/python-storage API. labels Jan 21, 2026

chandra-siri changed the base branch from main to update_handle_type January 21, 2026 18:37

chandra-siri assigned Pulkit0110 Jan 21, 2026

gemini-code-assist Bot reviewed Jan 21, 2026

View reviewed changes

chandra-siri assigned suni72, ankitaluthra1, jasha26 and googlyrahman Jan 22, 2026

Base automatically changed from update_handle_type to main January 22, 2026 07:30

suni72 previously approved these changes Jan 22, 2026

View reviewed changes

merge main and resolve conflicts

cb985b8

product-auto-label Bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Jan 22, 2026

rename to WRITE_HANDLE_BYTES

923f9cf

chandra-siri enabled auto-merge (squash) January 22, 2026 07:52

chandra-siri requested a review from suni72 January 22, 2026 08:29

Pulkit0110 approved these changes Jan 22, 2026

View reviewed changes

chandra-siri merged commit 5d9fafe into main Jan 22, 2026
18 checks passed

chandra-siri deleted the update_handle_on_recv branch January 22, 2026 09:26

release-please Bot mentioned this pull request Jan 22, 2026

chore(main): release 4.0.0 #1708

Closed

This was referenced Jan 29, 2026

chore: librarian release pull request: 20260129T115903Z #1731

Closed

chore: librarian release pull request: 20260202T123858Z #1736

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: update write handle on every recv()#1716

fix: update write handle on every recv()#1716
chandra-siri merged 9 commits into
mainfrom
update_handle_on_recv

chandra-siri commented Jan 21, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Jan 21, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

chandra-siri commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Jan 21, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

google/cloud/storage/_experimental/asyncio/async_write_object_stream.py (153-181)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chandra-siri commented Jan 21, 2026 •

edited

Loading