iframe-proxy

chandra-siri · 2026-01-21T16:32:18Z

feat: Add support for opening via write_handle and fix write_handle type

gemini-code-assist · 2026-01-21T16:32:46Z

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the type accuracy within the asynchronous object streaming components of the storage client and overhauling the associated system tests. The type hint adjustments provide clearer API contracts and improved static analysis. Concurrently, the test suite has been updated to leverage pytest's fixture system for managing asyncio event loops and gRPC client instances, resolving potential concurrency issues and making the tests more robust and maintainable.

Highlights

Type Hint Rectification: Updated type hints for 'handle', 'read_handle', and 'write_handle' parameters across several asynchronous object stream classes. This change refines the type definitions from generic 'bytes' to more specific types like '_storage_v2.BidiReadHandle', '_storage_v2.BidiWriteHandle', or 'Any' in the abstract base class, improving type safety and code clarity.
Asynchronous Test Refactoring: The system tests for asynchronous operations have been significantly refactored. This includes introducing session-scoped pytest fixtures for managing asyncio event loops and gRPC client instances, which helps prevent deadlocks and streamlines the execution of asynchronous tests.
New Test Case for Read Handles: A new test case, 'test_mrd_open_with_read_handle_over_cloud_path', was added to specifically validate the behavior of read handles when operating over cloud paths, ensuring comprehensive test coverage.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly rectifies the type hints for various handle parameters, changing them from bytes to more specific types like _storage_v2.BidiReadHandle and _storage_v2.BidiWriteHandle. This significantly improves type safety and code clarity. Additionally, the system tests in tests/system/test_zonal.py have been substantially refactored to manage the asyncio event loop at a session level, which is a great improvement for test stability and performance. I have one minor suggestion to improve docstring consistency.

chandra-siri · 2026-01-21T18:06:30Z

The base branch was changed.

…te_handle_type

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.2-0.20251119154421-36c3e21ad3ac Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91 <details><summary>google-cloud-storage: 3.9.0</summary> ## [3.9.0](v3.8.0...v3.9.0) (2026-02-02) ### Features * update generation for MRD (#1730) ([08bc708](08bc7082)) * add get_object method for async grpc client (#1735) ([0e5ec29](0e5ec29b)) * Add micro-benchmarks for reads comparing standard (regional) vs rapid (zonal) buckets. (#1697) ([1917649](1917649f)) * Add support for opening via `write_handle` and fix `write_handle` type (#1715) ([2bc15fa](2bc15fa5)) * add samples for appendable objects writes and reads ([2e1a1eb](2e1a1eb5)) * add samples for appendable objects writes and reads (#1705) ([2e1a1eb](2e1a1eb5)) * add context manager to mrd (#1724) ([5ac2808](5ac2808a)) * Move Zonal Buckets features of `_experimental` (#1728) ([74c9ecc](74c9ecc5)) * add default user agent for grpc (#1726) ([7b31946](7b319469)) * expose finalized_time in blob.py applicable for GET_OBJECT in ZB (#1719) ([8e21a7f](8e21a7fe)) * expose `DELETE_OBJECT` in `AsyncGrpcClient` (#1718) ([c8dd7a0](c8dd7a0b)) * send `user_agent` to grpc channel (#1712) ([cdb2486](cdb2486b)) * integrate writes strategy and appendable object writer (#1695) ([dbd162b](dbd162b3)) * Add micro-benchmarks for writes comparing standard (regional) vs rapid (zonal) buckets. (#1707) ([dbe9d8b](dbe9d8b8)) * add support for `generation=0` to avoid overwriting existing objects and add `is_stream_open` support (#1709) ([ea0f5bf](ea0f5bf8)) * add support for `generation=0` to prevent overwriting existing objects ([ea0f5bf](ea0f5bf8)) * add `is_stream_open` property to AsyncAppendableObjectWriter for stream status check ([ea0f5bf](ea0f5bf8)) ### Bug Fixes * receive eof while closing reads stream (#1733) ([2ef6339](2ef63396)) * update write handle on every recv() (#1716) ([5d9fafe](5d9fafe1)) * implement requests_done method to signal end of requests in async streams. Gracefully close streams. (#1700) ([6c16079](6c160794)) * implement requests_done method to signal end of requests in async streams. Gracefully close streams. ([6c16079](6c160794)) * instance grpc client once per process in benchmarks (#1725) ([721ea2d](721ea2dd)) * Fix formatting in setup.py dependencies list (#1713) ([cc4831d](cc4831d7)) * Change contructors of MRD and AAOW AsyncGrpcClient.grpc_client to AsyncGrpcClient (#1727) ([e730bf5](e730bf50)) </details>

chandra-siri added 5 commits January 21, 2026 14:48

chore: move system tests to single event loop

4ab7877

open with read handle works only in direct_path

4439039

remove unwated file

190498a

Merge branch 'main' into single_event_loop

93d64e0

fix: rectify handle type

35a9e05

product-auto-label Bot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. labels Jan 21, 2026

gemini-code-assist Bot reviewed Jan 21, 2026

View reviewed changes

Comment thread google/cloud/storage/_experimental/asyncio/async_appendable_object_writer.py

chandra-siri changed the base branch from main to single_event_loop January 21, 2026 17:44

feat: add support for opening via write handle

9bc6375

product-auto-label Bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jan 21, 2026

chandra-siri changed the title ~~fix: rectify handle type~~ feat: Add support for opening via write_handle and fix write_handle type Jan 21, 2026

chandra-siri changed the title ~~feat: Add support for opening via write_handle and fix write_handle type~~ feat: Add support for opening via write_handle and fix write_handle type Jan 21, 2026

chandra-siri marked this pull request as ready for review January 21, 2026 18:15

chandra-siri requested review from a team January 21, 2026 18:15

chandra-siri requested a review from a team as a code owner January 21, 2026 18:15

chandra-siri assigned Pulkit0110, suni72, googlyrahman, ankitaluthra1 and jasha26 Jan 21, 2026

googlyrahman previously approved these changes Jan 22, 2026

View reviewed changes

Base automatically changed from single_event_loop to main January 22, 2026 05:59

Merge branch 'main' of github.com:googleapis/python-storage into upda…

cf8ff85

…te_handle_type

chandra-siri enabled auto-merge (squash) January 22, 2026 06:03

chandra-siri requested a review from googlyrahman January 22, 2026 06:03

suni72 approved these changes Jan 22, 2026

View reviewed changes

chandra-siri merged commit 2bc15fa into main Jan 22, 2026
18 checks passed

chandra-siri deleted the update_handle_type branch January 22, 2026 07:30

release-please Bot mentioned this pull request Jan 22, 2026

chore(main): release 4.0.0 #1708

Closed

This was referenced Jan 29, 2026

chore: librarian release pull request: 20260129T115903Z #1731

Closed

chore: librarian release pull request: 20260202T123858Z #1736

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add support for opening via `write_handle` and fix `write_handle` type#1715

feat: Add support for opening via `write_handle` and fix `write_handle` type#1715
chandra-siri merged 7 commits into
mainfrom
update_handle_type

chandra-siri commented Jan 21, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot commented Jan 21, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

chandra-siri commented Jan 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

chandra-siri commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Jan 21, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

chandra-siri commented Jan 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chandra-siri commented Jan 21, 2026 •

edited

Loading