Devtools profiler calls by pkozlowski-opensource · Pull Request #59233 · angular/angular · GitHub
Skip to content

Devtools profiler calls - #59233

Closed
pkozlowski-opensource wants to merge 3 commits into
angular:mainfrom
pkozlowski-opensource:devtools_profiler_calls
Closed

Devtools profiler calls#59233
pkozlowski-opensource wants to merge 3 commits into
angular:mainfrom
pkozlowski-opensource:devtools_profiler_calls

Conversation

@pkozlowski-opensource

@pkozlowski-opensource pkozlowski-opensource commented Dec 18, 2024

Copy link
Copy Markdown
Member

No description provided.

@angular-robot angular-robot Bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Dec 18, 2024
@ngbot ngbot Bot added this to the Backlog milestone Dec 18, 2024
@pkozlowski-opensource

pkozlowski-opensource commented Dec 18, 2024

Copy link
Copy Markdown
Member Author

@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 18, 2024
@ngbot ngbot Bot modified the milestone: Backlog Dec 18, 2024
JeanMeche
JeanMeche reviewed Dec 18, 2024
View reviewed changes
Comment thread packages/core/src/application/application_ref.ts Outdated
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Dec 20, 2024
@ngbot ngbot Bot modified the milestone: Backlog Dec 20, 2024
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Jan 7, 2025
@ngbot ngbot Bot modified the milestone: Backlog Jan 7, 2025
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Jan 7, 2025
@ngbot ngbot Bot modified the milestone: Backlog Jan 7, 2025
@angular-robot angular-robot Bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Jan 7, 2025
@ngbot ngbot Bot removed this from the Backlog milestone Jan 7, 2025
@pkozlowski-opensource pkozlowski-opensource added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 13, 2025
@kirjs kirjs closed this in c4ad8fb Jan 13, 2025
kirjs pushed a commit that referenced this pull request Jan 13, 2025
@pkozlowski-opensource @kirjs
refactor(core): add profiler calls for tne newly introduced events (#…
435d31e 
…59233)

The set of profiler events was recently extended. This commit plugs
newly created events dispatch into the approriate places
of the Angular core.

PR Close #59233
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Jan 13, 2025
@AndrewKushnir
Revert "refactor(core): add profiler calls for tne newly introduced e…
3743f2b 
…vents (angular#59233)"

This reverts commit 435d31e.
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Jan 13, 2025
@AndrewKushnir
Revert "refactor(core): profiler takes null as a default instance (an…
f5f0e2e 
…gular#59233)"

This reverts commit c4ad8fb.
kirjs pushed a commit that referenced this pull request Jan 13, 2025
@AndrewKushnir @kirjs
Revert "refactor(core): add profiler calls for tne newly introduced e…
e77df14 
…vents (#59233)" (#59506)

This reverts commit 435d31e.

PR Close #59506
kirjs pushed a commit that referenced this pull request Jan 13, 2025
@AndrewKushnir @kirjs
Revert "refactor(core): profiler takes null as a default instance (#5…
412ac30 
…9233)" (#59506)

This reverts commit c4ad8fb.

PR Close #59506
@AndrewKushnir

AndrewKushnir commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

Reopening this PR, since it was reverted due to some issues with the DevTools, see #59506 for additional info.

@AndrewKushnir AndrewKushnir reopened this Jan 13, 2025
@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jan 14, 2025
@pkozlowski-opensource
refactor(core): profiler takes null as a default instance
cfb5fc6 
Several profiler calls don't have any meaningful instance when
producing a profiling event. This commit changes the default
instance value to null to sreamline profiler invocations.
@pkozlowski-opensource
refactor(core): add profiler calls for tne newly introduced events
27455e7 
The set of profiler events was recently extended. This commit plugs
newly created events dispatch into the approriate places
of the Angular core.
@pkozlowski-opensource
fixup! refactor(core): add profiler calls for tne newly introduced ev…
fb5795b 
…ents
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker labels Jan 14, 2025
@pkozlowski-opensource

pkozlowski-opensource commented Jan 14, 2025

Copy link
Copy Markdown
Member Author

caretaker note: maybe do a separate G3 sync for this one in case we need to revert again...

@kirjs

kirjs commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 815f1b1.

The changes were merged into the following branches: main

@kirjs kirjs closed this in 9c835e8 Jan 14, 2025
kirjs pushed a commit that referenced this pull request Jan 14, 2025
@pkozlowski-opensource @kirjs
refactor(core): add profiler calls for tne newly introduced events (#…
815f1b1 
…59233)

The set of profiler events was recently extended. This commit plugs
newly created events dispatch into the approriate places
of the Angular core.

PR Close #59233
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@pkozlowski-opensource @PrajaktaB27
refactor(core): profiler takes null as a default instance (angular#59233
75ce80b 
)

Several profiler calls don't have any meaningful instance when
producing a profiling event. This commit changes the default
instance value to null to sreamline profiler invocations.

PR Close angular#59233
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@pkozlowski-opensource @PrajaktaB27
refactor(core): add profiler calls for tne newly introduced events (a…
0251712 
…ngular#59233)

The set of profiler events was recently extended. This commit plugs
newly created events dispatch into the approriate places
of the Angular core.

PR Close angular#59233
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Feb 14, 2025

Copy link
Copy Markdown

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche left review comments
@AleksanderBodurri AleksanderBodurri AleksanderBodurri approved these changes
@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@pkozlowski-opensource @AndrewKushnir @kirjs @JeanMeche @AleksanderBodurri