Revert PR #59233 "Devtools profiler calls" by AndrewKushnir · Pull Request #59506 · angular/angular · GitHub
Skip to content

Revert PR #59233 "Devtools profiler calls" - #59506

Closed
AndrewKushnir wants to merge 2 commits into
angular:mainfrom
AndrewKushnir:revert_59233
Closed

Revert PR #59233 "Devtools profiler calls"#59506
AndrewKushnir wants to merge 2 commits into
angular:mainfrom
AndrewKushnir:revert_59233

Conversation

@AndrewKushnir

@AndrewKushnir AndrewKushnir commented Jan 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reason for revert: Angular DevTools code fails at handling null as an instance passed to the profile call (see here).

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jan 13, 2025
@AndrewKushnir
AndrewKushnir requested a review from kirjs January 13, 2025 21:41
@AndrewKushnir AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Jan 13, 2025
@AndrewKushnir

AndrewKushnir commented Jan 13, 2025

Copy link
Copy Markdown
Contributor Author

@AndrewKushnir AndrewKushnir added PullApprove: disable merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit labels Jan 13, 2025
@AndrewKushnir

AndrewKushnir commented Jan 13, 2025

Copy link
Copy Markdown
Contributor Author

Caretaker note: this PR is ready for merge.

@kirjs

kirjs commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 412ac30.

The changes were merged into the following branches: main

@kirjs kirjs closed this in e77df14 Jan 13, 2025
kirjs pushed a commit that referenced this pull request Jan 13, 2025
@AndrewKushnir @kirjs
Revert "refactor(core): profiler takes null as a default instance (#5…
412ac30 
…9233)" (#59506)

This reverts commit c4ad8fb.

PR Close #59506
@AndrewKushnir AndrewKushnir mentioned this pull request Jan 13, 2025
Closed
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@AndrewKushnir @PrajaktaB27
Revert "refactor(core): add profiler calls for tne newly introduced e…
4c19864 
…vents (angular#59233)" (angular#59506)

This reverts commit 435d31e.

PR Close angular#59506
PrajaktaB27 pushed a commit to PrajaktaB27/angular that referenced this pull request Feb 7, 2025
@AndrewKushnir @PrajaktaB27
Revert "refactor(core): profiler takes null as a default instance (an…
adf5839 
…gular#59233)" (angular#59506)

This reverts commit c4ad8fb.

PR Close angular#59506
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Feb 13, 2025

Copy link
Copy Markdown

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kirjs kirjs kirjs approved these changes
@AleksanderBodurri AleksanderBodurri Awaiting requested review from AleksanderBodurri

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note PullApprove: disable target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewKushnir @kirjs