Comparing 10.0.2...10.0.3 · angular/angular · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 10.0.2
Choose a base ref
...
head repository: angular/angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 10.0.3
Choose a head ref
  • 13 commits
  • 27 files changed
  • 7 contributors

Commits on Jun 30, 2020

  1. docs: add missing single quote (#37854)

    The current code is missing a single quote at the end of the import.
    
    (cherry picked from commit e13171e)
    
    PR Close #37854
    alan-agius4 authored and AndrewKushnir committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    9833552 View commit details
    Browse the repository at this point in the history
  2. docs: clean up api doc in core (#37053)

    Add introductions to usage examples and edit descriptions to be more complete and consistent with current API reference styles
    
    PR Close #37053
    jbogarthyde authored and AndrewKushnir committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    842b6a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. docs: mention for depreciation for Testbed.get() (#37815)

    As mention in https://angular.io/guide/deprecations for this API, it may be important mention for this to make developers migrate or avoid using it
    
    PR Close #37815
    OmarioHassan authored and alxhub committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    242ef1a View commit details
    Browse the repository at this point in the history
  2. fix(dev-infra): fix typo in ng-dev config (#37862)

    The logic to exclude certain types of commits (specifically 'docs' ones) was implemented in c5b125b. The ng-dev config was updated in the followup commit acf3cff, but there was a typo that prevented the new logic from being activated. This commit updates the name of the config option in the ng-dev config to the right one (minBodyLengthTypeExcludes).
    
    PR Close #37862
    AndrewKushnir authored and alxhub committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    2adcad6 View commit details
    Browse the repository at this point in the history
  3. fix(core): handle spaces after select and plural ICU keywords (#3…

    …7866)
    
    Currently when the `plural` or `select` keywords in an ICU contain trailing spaces (e.g. `{count, select , ...}`), these spaces are also included into the key names in ICU vars (e.g. "VAR_SELECT "). These trailing spaces are not desirable, since they will later be converted into `_` symbols while normalizing placeholder names, thus causing mismatches at runtime (i.e. placeholder will not be replaced with the correct value). This commit updates the code to trim these spaces while generating an object with placeholders, to make sure the runtime logic can replace these placeholders with the right values.
    
    PR Close #37866
    AndrewKushnir authored and alxhub committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    790bb94 View commit details
    Browse the repository at this point in the history
  4. build(docs-infra): improve applying post-install patches (#37896)

    In `aio/`, we have a mechanism to apply patches in a `postinstall` hook.
    See `aio/tools/cli-patches/README.md` for more info.
    
    Previously, we had to update `aio/tools/cli-patches/patch.js` to list
    each `.patch` file separately. While working on #37688, I found it
    helpful for the script to automatically pick up `.patch` files.
    
    This commit updates the script to automatically pick up and apply
    `.patch` files from the `aio/tools/cli-patches/` directory. If one wants
    to keep a `.patch` file but not apply it, they can change the file's
    extension or move it to a sub-directory (without having to update the
    script).
    
    PR Close #37896
    gkalpak authored and alxhub committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    0f74479 View commit details
    Browse the repository at this point in the history
  5. refactor(docs-infra): use Sass variable for top-bar hamburger button …

    …show/hide threshold (#37938)
    
    Use a Sass variable for the screen width break-point at which the
    top-bar hamburger button is hidden/shown. This allows more easily
    updating the break-point.
    
    PR Close #37938
    gkalpak authored and alxhub committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    1c168c3 View commit details
    Browse the repository at this point in the history
  6. refactor(docs-infra): decouple showing the top-menu in top-bar from s…

    …howing the sidenav (#37938)
    
    As part of angular.io's responsive layout, the following rules are
    applied:
    - On wide screens, a menu is shown in the top-bar and the sidenav is
      shown side-by-side with the docs content.
    - On narrow screens, the top-menu is moved from the top-bar to the
      sidenav and the sidenav is closed by default and floats over the
      content when manually opened.
    
    Previously, the break-points at which the top-menu was shown in the
    top-bar and the sidenav was shown side-by-side with the content were the
    same (using a single variable).
    
    This commit decouples the two break-points to make it possible to use
    different values in the future.
    
    PR Close #37938
    gkalpak authored and alxhub committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    d09a628 View commit details
    Browse the repository at this point in the history
  7. fix(docs-infra): prevent search-bar from overlapping nav-items (#37938)

    As part of angular.io's responsive layout, the menu shown in the top-bar
    is collapsed into the sidenav on narrow screens at the point where the
    search-bar (on the right side of the top-bar) would overlap with the
    menu's nav-items.
    
    Previously, the value used as break-point would work on marketing pages,
    where the hamburger button is not shown on wide screens. However, on
    docs pages (where the hamburger button is always shown, pushing the menu
    further to the right), the search-bar would still overlap the menu
    nav-items on some resolutions.
    
    This commit fixes it by raising the screen width threshold at a value
    that ensures there is no overlap even on pages where the hamburger
    button is visible alongside the top-bar menu.
    
    Fixes #37937
    
    PR Close #37938
    gkalpak authored and alxhub committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    9d54b3a View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. feat(dev-infra): merge script should link to original commit when che…

    …rry-picking with API strategy (#37889)
    
    The merge script uses `git cherry-pick` for both the API merge strategy
    and the autosquash strategy. It uses cherry-pick to push commits to
    different target branches (e.g. into the `10.0.x` branch).
    
    Those commits never point to the commits that landed in the primary
    Github branch though. For the autosquash strategy the pull request number
    is always included, so there is a way to go back to the source. On the other
    hand though, for commits cherry-picked in the API merge strategy, the
    pull request number might not always be included (due to Github's
    implementation of the rebase merge method).
    
    e.g.
    angular/components@27f5271
    
    For those cases we'd want to link the cherry-picked commits to the
    original commits so that the corresponding PR is easier to track
    down. This is not needed for the autosquash strategy (as outlined
    before), but it would have been good for consistency. Unfortunately
    though this would rather complicate the strategy as the autosquash
    strategy cherry-picks directly from the PR head, so the SHAs that
    are used in the primary branch are not known.
    
    PR Close #37889
    devversion authored and alxhub committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    2605fc4 View commit details
    Browse the repository at this point in the history
  2. docs: minor fixes to docs related to updating to v10 (#37897)

    This commit includes a couple of minor fixes to docs related to updating
    to v10:
    - Fix markdown link in "Updating to Angular version 10" guide.
    - Correctly display numbered list in
      "Solution-style `tsconfig.json` migration" guide.
    
    PR Close #37897
    gkalpak authored and alxhub committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    f296fea View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. build: filter out duplicate cherry-picked commits in changelog (#37956)

    Often changelogs are generated from the patch branch and then
    cherry-picked into the `CHANGELOG.md` file in `master` for
    better access and readability. This is problematic though as
    `conventional-changelog` (the tool we use for generating the
    changelog), will duplicate commits when a future changelog
    is generated from `master` then (i.e. for a new minor release).
    
    This happens because conventional-changelog always generates the
    changelog from the latest tag in a given branch to `HEAD`. The
    tag in the patch branch does not correspond to any SHA in `master`
    so the intersection of commits is not automatically omitted.
    
    We work around this naively (until we have a better tool provided
    by dev-infra), by deduping commits that are already part of the
    changelog. This has proven to work as expected in the components
    repo.
    
    PR Close #37956
    devversion authored and alxhub committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    d2886b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f24972b View commit details
    Browse the repository at this point in the history
Loading