{{ message }}
Repository navigation
fix(dev-infra): fix typo in ng-dev config - #37862
Closed
AndrewKushnir wants to merge 1 commit into
Closed
AndrewKushnir wants to merge 1 commit into
AndrewKushnir wants to merge 1 commit into
Conversation
The logic to exclude certain types of commits (specifically 'docs' ones) was implemented in angular@c5b125b. The ng-dev config was updated in the followup commit angular@acf3cff, but there was a typo that prevented the new logic from being activated. This commit updates the name of the config option in the ng-dev config to the right one (minBodyLengthTypeExcludes).
AndrewKushnir
added
type: bug/fix
action: review
This was referenced Jun 30, 2020
gkalpak
approved these changes
Jul 1, 2020
jelbourn
approved these changes
Jul 2, 2020
jelbourn
left a comment
jelbourn
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Reviewed-for: global-approvers
jelbourn
added
action: merge
alxhub
pushed a commit
that referenced
this pull request
Jul 6, 2020
The logic to exclude certain types of commits (specifically 'docs' ones) was implemented in c5b125b. The ng-dev config was updated in the followup commit acf3cff, but there was a typo that prevented the new logic from being activated. This commit updates the name of the config option in the ng-dev config to the right one (minBodyLengthTypeExcludes). PR Close #37862
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
The logic to exclude certain types of commits (specifically 'docs' ones) was implemented in angular@c5b125b. The ng-dev config was updated in the followup commit angular@acf3cff, but there was a typo that prevented the new logic from being activated. This commit updates the name of the config option in the ng-dev config to the right one (minBodyLengthTypeExcludes). PR Close angular#37862
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic to exclude certain types of commits (specifically 'docs' ones) was implemented in c5b125b. The ng-dev config was updated in the followup commit acf3cff, but there was a typo that prevented the new logic from being activated. This commit updates the name of the config option in the ng-dev config to the right one (minBodyLengthTypeExcludes).
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?