docs: mention for depreciation for `TestBed.get()` by OmarioHassan · Pull Request #37815 · angular/angular · GitHub
Skip to content

docs: mention for depreciation for TestBed.get() - #37815

Closed
OmarioHassan wants to merge 1 commit into
angular:masterfrom
OmarioHassan:patch-1
Closed

OmarioHassan wants to merge 1 commit into
angular:masterfrom
OmarioHassan:patch-1

Conversation

@OmarioHassan

@OmarioHassan OmarioHassan commented Jun 29, 2020 •

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

There is no mention for the depreciation in v12 for TestBed.get() and this is announced in https://angular.io/guide/deprecations

Issue Number: N/A

What is the new behavior?

As mention in https://angular.io/guide/deprecations for this API, it may be important mention for this to make developers migrate or avoid using it

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@googlebot

Copy link
Copy Markdown

@pullapprove
pullapprove Bot requested a review from AndrewKushnir June 29, 2020 07:26
@OmarioHassan

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@OmarioHassan OmarioHassan changed the title docs: mention for depreciation for Testbed.get() docs: mention for depreciation for TestBed.get() Jun 29, 2020
Comment thread aio/content/guide/testing.md Outdated
@AndrewKushnir AndrewKushnir added area: testing Issues related to Angular testing features, such as TestBed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 29, 2020
@ngbot ngbot Bot modified the milestone: needsTriage Jun 29, 2020
@OmarioHassan

OmarioHassan commented Jun 30, 2020 •

Copy link
Copy Markdown
Contributor Author

@AndrewKushnir sorry for re-requesting review it's my fault I will wait for @kapunahelewong response

@AndrewKushnir AndrewKushnir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the update @OmarioHasan.

@OmarioHassan

Copy link
Copy Markdown
Contributor Author

@AndrewKushnir it's my first contribution thanks for your encouragement it will never be the last

@kapunahelewong kapunahelewong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much, @OmarioHasan!

Reviewed-for: global-docs-approvers

As mention in https://angular.io/guide/deprecations for this API, it may be important mention for this to make developers migrate or avoid using it
@kapunahelewong

Copy link
Copy Markdown
Contributor

Hey @OmarioHasan, I just squashed the three commits so we'd just have one. (I only noticed after approving.) As soon as everything passes, I can mark it for merge. Woo!

@OmarioHassan

OmarioHassan commented Jul 1, 2020 •

Copy link
Copy Markdown
Contributor Author

@kapunahelewong It's really an awesome feeling for my first contribution to my lovely framework, I'm very glad to your encourage and hope to do more

@OmarioHassan

Copy link
Copy Markdown
Contributor Author

@kapunahelewong it's ready now 🎉🎉🎉

@OmarioHassan

Copy link
Copy Markdown
Contributor Author

@kapunahelewong is there any missed changes from my side

@kapunahelewong kapunahelewong added effort1: hours risk: low type: bug/fix and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 2, 2020
@ngbot ngbot Bot modified the milestones: needsTriage, Backlog Jul 2, 2020
@kapunahelewong

Copy link
Copy Markdown
Contributor

@OmarioHasan, you have everything perfectly ready!

@kapunahelewong kapunahelewong added the action: merge The PR is ready for merge by the caretaker label Jul 2, 2020
@alxhub alxhub closed this in a5c3073 Jul 6, 2020
alxhub pushed a commit that referenced this pull request Jul 6, 2020
As mention in https://angular.io/guide/deprecations for this API, it may be important mention for this to make developers migrate or avoid using it

PR Close #37815
@angular-automatic-lock-bot

Copy link
Copy Markdown

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 6, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
As mention in https://angular.io/guide/deprecations for this API, it may be important mention for this to make developers migrate or avoid using it

PR Close angular#37815
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: testing Issues related to Angular testing features, such as TestBed cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants