Repository navigation
docs: mention for depreciation for TestBed.get() - #37815
OmarioHassan wants to merge 1 commit into
Conversation
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Testbed.get()TestBed.get()
|
@AndrewKushnir sorry for re-requesting review it's my fault I will wait for @kapunahelewong response |
AndrewKushnir
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for the update @OmarioHasan.
|
@AndrewKushnir it's my first contribution thanks for your encouragement it will never be the last |
kapunahelewong
left a comment
There was a problem hiding this comment.
LGTM! Thank you so much, @OmarioHasan!
Reviewed-for: global-docs-approvers
As mention in https://angular.io/guide/deprecations for this API, it may be important mention for this to make developers migrate or avoid using it
|
Hey @OmarioHasan, I just squashed the three commits so we'd just have one. (I only noticed after approving.) As soon as everything passes, I can mark it for merge. Woo! |
|
@kapunahelewong It's really an awesome feeling for my first contribution to my lovely framework, I'm very glad to your encourage and hope to do more |
|
@kapunahelewong it's ready now 🎉🎉🎉 |
|
@kapunahelewong is there any missed changes from my side |
|
@OmarioHasan, you have everything perfectly ready! |
As mention in https://angular.io/guide/deprecations for this API, it may be important mention for this to make developers migrate or avoid using it PR Close #37815
As mention in https://angular.io/guide/deprecations for this API, it may be important mention for this to make developers migrate or avoid using it PR Close angular#37815

PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is no mention for the depreciation in v12 for
TestBed.get()and this is announced in https://angular.io/guide/deprecationsIssue Number: N/A
What is the new behavior?
As mention in https://angular.io/guide/deprecations for this API, it may be important mention for this to make developers migrate or avoid using it
Does this PR introduce a breaking change?
Other information